GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Align partial construction and state controls by youknowdot · Pull Request #9679 · RustPython/RustPython

Conversation

@youknowdot

@youknowdot youknowdot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep nested partial keyword dictionaries isolated and flatten only partials whose instance dictionary remains absent.
  • Recognize native Placeholder values, validate trailing placeholders before flattening, and reuse shared constructor argument binding with lazy instance-dictionary allocation.
  • Validate restored state before tuple-subclass callbacks or state changes, preserve supplied instance dictionary identity, and copy keyword subclasses without rehashing stored keys.
  • Preserve absent versus allocated-empty dictionaries in reduction.

Invalid state is rejected before mutation. Successful field replacement remains sequential, matching CPython rather than claiming transactional reentrant updates.

Reference: CPython 3.15.0 partial construction and state restoration.

Validation

  • Eight bounded CPython 3.15 reference groups passed, including fresh-dictionary, flattening, callback, identity, and invalid-state cases.
  • Independent source review caught and resolved an eager-dictionary allocation issue; final formatting and whitespace checks passed.
  • Final focused VM, host-env and stdlib check and strict Clippy with rustpython-stdlib/threading passed. Normal repository commit hooks passed.
  • RustPython runtime, full workspace/C-API suites, and cross-platform execution were not run. No test, Lib, workflow, or marker edits.

AI assistance: OpenAI Codex performed source comparison, implementation, reference probes, and independent source review; model version was not exposed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
youknowdot added 3 commits November 4, 2026 08:47
@youknowdot
Align partial construction and state controls
e8365d2
Preserve nested keyword ownership and lazy instance dictionaries, use
native Placeholder identity, and share constructor argument binding.
Validate restored state before callback conversion, retain instance dict
identity, and copy stored keyword entries without rehashing keys.

Assisted-by: OpenAI Codex:model version not exposed
@youknowdot
Use the existing positional argument slice conversion
41cb1ee
PosArgs exposes its borrowed slice through AsRef rather than as_slice.

Assisted-by: OpenAI Codex:model version not exposed
@youknowdot
Move the owned partial callable without cloning
d41e7e0
Avoid a redundant strong reference when constructing a nonnested partial.

Assisted-by: OpenAI Codex:model version not exposed
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

  • X
  • Mastodon
  • Reddit
  • LinkedIn
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowdot youknowdot mentioned this pull request Nov 4, 2026
Align LRU cache keys and callback controls #9681
Merged
@codspeed

codspeed Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:partial-state-controls-group-20261103 (d41e7e0) with main (0b081b0)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

youknowone
youknowone approved these changes Nov 5, 2026
View reviewed changes
@youknowone
youknowone marked this pull request as ready for review November 5, 2026 02:13
@youknowone
youknowone merged commit 3c708b9 into RustPython:main Nov 5, 2026
21 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-05T02:13:45.268561Z
We couldn’t complete this review. Comment @codex review to try again.
d41e7e0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@youknowdot youknowdot mentioned this pull request Nov 5, 2026
Replace runtime type-name checks with type identity #9723
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@youknowdot @youknowone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.