GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Align object reduction and state callback controls by youknowdot · Pull Request #9716 · RustPython/RustPython Conversation
Contributor
SummaryAlign object reduction and state callback controls with Python 3.15 in one production Rust file (+186/-128).
Existing binding, lookup, dictionary and method primitives are reused. No per-function keyword parser, test, Lib or workflow edits are introduced. ValidationCompared with pinned CPython object reduction/state. The 29-case reference oracle reproduced exactly. Independent source review and additional safe failure, copyreg, class-mutation, slot-finalizer and temporary-protocol probes passed. Ordinary classes/subclasses and legal class reassignment were used; no malformed native layouts or unsafe cycles were exercised. These are CPython reference results and source review, not a RustPython runtime pass. Native RustPython execution, full workspace/C-API suites and separate cross-platform graphs remain unperformed; hosted CI is required. Limits and integrationGeneric nested tuple member destruction still differs from CPython's reverse order. This patch fixes the changed top-level owners but does not redesign generic tuple teardown or claim full nested-container finalizer parity. Fresh relevant PR patches were checked and do not duplicate this group. Composing with #9715 requires resolving the object.rs import hunk by retaining both its AI-assisted implementation and independent review using OpenAI Codex; model version is not exposed. Final validation: threaded host-env/VM/stdlib cargo check passed in 1m12s and all-targets Clippy in 3m03s. Diagnostics exactly match the 12 unchanged baseline warnings. Normal repository commit hooks passed; no suppressions or unrelated baseline edits.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Preserve signed protocol arguments, dynamic state dispatch, original slot keys, and newargs ownership through shared lookup and conversion paths. Assisted-by: OpenAI Codex:model version not exposed
b522122 to
fad2db2
Compare
Preserve callback ownership, release ordering, and retained argument owners. Assisted-by: Codex:model-version-unavailable
Assisted-by: Codex:model-version-unavailable
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.