GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||
GeezerVison is showing github.com — Match codec and timer signature defaults to Python 3.15 by youknowdot · Pull Request #9741 · RustPython/RustPython Conversation
Contributor
SummaryMatch the displayed defaults of five native APIs to CPython 3.15.0's Argument Clinic declarations:
These changes use the existing The existing signature snippet checks the raw default spellings (normalizing Clinic's line wrapping), inspect's resolved defaults where representable, and omitted-versus-explicit dictionary behavior. ReferenceCompared directly with the generated Clinic headers at CPython v3.15.0:
Validation
CPython 3.15 execution will be checked by the existing CI snippet job; local comparisons against older CPython versions are not being used as the reference.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsAssisted-by: OpenAI Codex: model version not exposed Assisted-by: OpenAI Codex: model version not exposed
|
There was an error while loading. Please reload this page.
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e9cd8fa39
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| assert zlib._ZlibDecompressor().decompress(zlib.compress(b"signature defaults")) == ( | ||
| b"signature defaults" | ||
| ) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplicating the existing zlib round-trip test
This round-trip assertion duplicates ZlibDecompressorTest.testDecompress in Lib/test/test_zlib.py:1051–1065: both compress bytes, construct _ZlibDecompressor() with its defaults, and verify the decompressed result. It adds no signature-specific coverage and violates AGENTS.md's explicit prohibition on adding snippet tests that duplicate Lib/test coverage. Keep the new signature assertions and rely on the existing standard-library test for runtime-default validation.
AGENTS.md reference: AGENTS.md:L119-L119
Useful? React with 👍 / 👎.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.