GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||
GeezerVison is showing github.com — Align faulthandler watchdog timeouts with CPython by youknowdot · Pull Request #9775 · RustPython/RustPython Conversation
Contributor
Summary
This patch does not change signal callbacks or frame traversal. Existing watchdog Validation
ReferenceCPython 3.15.1 faulthandler implementation and Clinic wrappers. AI assistance: OpenAI Codex assisted implementation, review, and validation. Both commits include an
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
|
|
||
| # Faulthandler watchdogs use the same signed-nanosecond conversion as sleep. | ||
| import faulthandler |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
this is improper. do not add import faulthandler in stdlib_time. separate stdlib_faulthandler for this
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Moved the timeout and register regression tests into stdlib_faulthandler.py in f88bd7d, leaving stdlib_time.py and stdlib_signal.py unchanged. The dedicated snippet passes on RustPython and CPython 3.15.1.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
f88bd7d to
3d437ee
Compare
3d437ee to
4669cb0
Compare
Use the shared signed PyTime conversion and platform bounds, accept timeout/signum keywords, and preserve the watchdog deadline across notifications. Add safe numeric-conversion and notification regression coverage. Assisted-by: OpenAI Codex:model version not exposed
Keep the native-platform guard separate so the tests_outside_test_module Clippy lint recognizes the cfg(test) module. Assisted-by: OpenAI Codex:model version not exposed
Move watchdog timeout and signal-registration probes into stdlib_faulthandler.py, preserving their assertions and guards. Keep the time and signal snippets focused on their own modules. Assisted-by: OpenAI Codex:model version not exposed
4669cb0 to
261911f
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.