GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow overriding the way a SqlConnection is created by CumpsD · Pull Request #119 · SQLStreamStore/SQLStreamStore

This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Conversation

@CumpsD

@CumpsD CumpsD commented Apr 28, 2018

Copy link
Copy Markdown
Contributor

By default a connection is still created using new SqlConnection(connectionstring), except the user now has the ability to override this behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CumpsD
Allow overriding the way a SqlConnection is created
e63e209
@damianh damianh added this to the v1.1.2 milestone May 2, 2018
@damianh damianh self-assigned this May 2, 2018
@damianh
damianh merged commit d4cd654 into SQLStreamStore:master May 2, 2018
@damianh

damianh commented May 2, 2018

Copy link
Copy Markdown
Member

Merged, thanks @CumpsD !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@damianh damianh added the enhancement label May 27, 2018
@CumpsD

CumpsD commented Jul 20, 2018

Copy link
Copy Markdown
Contributor Author

@damianh it took a while before I managed to use this in our codebase, and I realised, it would've been better to let it make a DbConnect instead of a SqlConnection. I am wrapping a SqlConnection in a class (inheriting from DbConnection since SqlConnection is sealed)

What do you think? Does it make sense to change this to DbConnection?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@damianh damianh

Labels

enhancement

Projects

None yet

Milestone

v1.1.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@CumpsD @damianh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.