GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allows setting of $deleted stream's metadata by damianh · Pull Request #131 · SQLStreamStore/SQLStreamStore

This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Conversation

@damianh

@damianh damianh commented May 20, 2018

Copy link
Copy Markdown
Member

Allows settings the metadata (maxAge / maxCount) for $deleted stream via standard API.

Fixes #130 .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@damianh damianh self-assigned this May 20, 2018
@damianh
damianh requested review from thefringeninja and yreynhout May 20, 2018 19:39
@damianh damianh changed the title Allo setting of $deleted streams metadata Allows setting of $deleted streams metadata May 20, 2018
@damianh damianh changed the title Allows setting of $deleted streams metadata Allows setting of $deleted stream's metadata May 20, 2018
@damianh

damianh commented May 20, 2018

Copy link
Copy Markdown
Member Author

This PR builds on #129 , hence the extra commits.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@damianh damianh added the enhancement label May 20, 2018
@damianh
damianh force-pushed the master branch from 3b2614a to 110929c Compare May 20, 2018 20:54
damianh added 2 commits May 21, 2018 13:36
@damianh
Add test to set $deleted metadata
8e257c6
@damianh
On SetStreamMetadata and GetStreamMetadata relax the guard clauses to…
0163392 
… allow setting the stream metadata for $deleted (Deleted.DeletedStreamId).
@damianh
damianh merged commit 15afc62 into SQLStreamStore:master May 21, 2018
@damianh
damianh deleted the purge-deleted branch July 1, 2018 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yreynhout yreynhout Awaiting requested review from yreynhout
@thefringeninja thefringeninja Awaiting requested review from thefringeninja

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@damianh damianh

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@damianh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.