GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add a failing concurrency test by roetlich · Pull Request #480 · SQLStreamStore/SQLStreamStore

This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Conversation

@roetlich

@roetlich roetlich commented Nov 25, 2020

Copy link
Copy Markdown
Contributor

Add a test to AcceptanceTests.AppendStream that fails for postgres but passes for all other DBs. This is to reproduce a bug with concurrent appends in postgres, see: #478

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thefringeninja

thefringeninja commented Nov 26, 2020

Copy link
Copy Markdown
Contributor

@roetlich can you rebase your PR please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@roetlich
roetlich force-pushed the failing-concurrency-test-for-postgres branch from c5b0a26 to dc18132 Compare November 26, 2020 09:18
@stoft

stoft commented Dec 18, 2020

Copy link
Copy Markdown

@thefringeninja rebased.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@roetlich roetlich mentioned this pull request Mar 31, 2021
Concurrent appends to same stream and ExpectedVersion.Any on Postgres throws WrongExpectedVersion #478
Open
@Mousaka

Mousaka commented May 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Me and @EddieChoCho tried to find a solution for this but has not succeeded yet. However, we found out that it's this exception causing this test to fail:
https://github.com/SQLStreamStore/SQLStreamStore/blob/master/src/SqlStreamStore.Postgres/PgSqlScripts/EnforceIdempotentAppend.sql#L34
EddieChoCho and roetlich reacted with thumbs up emoji stoft and roetlich reacted with heart emoji
All reactions
  • 👍 2 reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thefringeninja

thefringeninja commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Sorry for the late reply. Is this something that fails occasionally?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thefringeninja thefringeninja self-assigned this Jul 20, 2021
@roetlich

roetlich commented Jul 20, 2021

Copy link
Copy Markdown
Contributor Author

When I made this PR, the test was failing consistently for me locally. AFAIR it also failed in the CI here in GitHub, but it was shown as a passing check by some mistake. But it's been a few month, but maybe with current code that's not the case anymore and I might be misremembering something.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thefringeninja

thefringeninja commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

Part of the problem is that I can't re-run the checks associated with the PR. I guess it's because you are not a committer? I'll take a closer look at this soon
Mousaka and roetlich reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mousaka

Mousaka commented Jul 21, 2021

Copy link
Copy Markdown

It was consistently failing for me locally as well when I was running it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@roetlich
roetlich force-pushed the failing-concurrency-test-for-postgres branch from 2e4256e to dc18132 Compare July 21, 2021 12:43
@roetlich @stoft Till
Add a failing concurrency test
82f9e0b 
Add a test to AcceptanceTests.AppendStream that fails for postgres but passes for all other DBs. This is to reproduce a bug with concurrent appends in postgres, see: SQLStreamStore#478

Co-authored-by: Rasmus Larsson <[email protected]>
@roetlich
roetlich force-pushed the failing-concurrency-test-for-postgres branch from dc18132 to 82f9e0b Compare July 21, 2021 12:45
@roetlich

roetlich commented Jul 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I rebased this on top of your master, so the CI was retriggered. Now it even shows which test is failing! 😁
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@roetlich

roetlich commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

@thefringeninja is there any update on this? Can I help you with testing this in any way?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@thefringeninja thefringeninja

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@roetlich @thefringeninja @stoft @Mousaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.