GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: add docstring for discretes support in `AbstractDiffEqArray` by AayushSabharwal · Pull Request #441 · SciML/RecursiveArrayTools.jl

Conversation

@AayushSabharwal

@AayushSabharwal AayushSabharwal commented Apr 25, 2025

Copy link
Copy Markdown
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AayushSabharwal
docs: add docstring for discretes support in AbstractDiffEqArray
b7cda10
ChrisRackauckas
ChrisRackauckas reviewed Apr 25, 2025
View reviewed changes
Comment thread src/RecursiveArrayTools.jl
* `t` which holds the times of each timestep.
* `discretes` (optional) which contains a
`SymbolicIndexingInterface.ParameterTimeseriesCollection` to allow storing and indexing
discrete variables. Indexing behavior is handled via `SymbolicIndexingInterface.getu`.

@ChrisRackauckas ChrisRackauckas Apr 25, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a mention of symbolic indexing for DiffEqArray in a # Symbolic Array Interface section? And any other requirements you implicitly have put on DiffEqArray to make that work should get mentioned.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AayushSabharwal @ChrisRackauckas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.