GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add serialization by pkspyder007 · Pull Request #56 · SciRuby/numruby

Conversation

@pkspyder007

@pkspyder007 pkspyder007 commented Jan 22, 2021

Copy link
Copy Markdown

Description

Added serialization for NMatrix class using Marshal module and custom implementation of load and dump functions.
Default Marshal serialization methods threw error so We needed to create our own serialization/deserialization strategies.
nm_int is the default fallback for dtype if it's not nm_float64 or nm_bool

Closes #35

(Explain how this PR changes numruby.)
This PR adds the ability for NMatrix to serialize the class objects which can be used to store the data in a file for future and to pass it between different processes and to be utilized

Test Plan

the test is written for comparing the original object and the one after serialization and deserialization
it checks for nm_float64, nm_int, and nm_bool dtypes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pkspyder007
add serialization
2b83089
@prasunanand
prasunanand requested a review from Uditgulati January 23, 2021 04:47
@prasunanand

prasunanand commented Jan 23, 2021

Copy link
Copy Markdown
Member

@pkspyder007 CI is failing. Can you debug ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkspyder007

pkspyder007 commented Jan 23, 2021

Copy link
Copy Markdown
Author

@prasunanand According to my checking ,CI is failing due to the bundler version compatibility. Adding a Gemlock file similar to package.lock in npm should lock all the version of gems and bundler we are using.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkspyder007
FIX CI build fail
b1408e8
@pkspyder007

pkspyder007 commented Jan 24, 2021

Copy link
Copy Markdown
Author

@prasunanand If I add the Gemfile.lock the 5th test passes but the travis CI build fails and on removing Gemfile.lock the 5th test fails. You can see the result here
I read the error message in Travis build log I think the Issue is only with versions that we use of bundler and ruby.
So this would be a tradeoff between keeping the lock file vs not.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkspyder007

pkspyder007 commented Feb 19, 2021

Copy link
Copy Markdown
Author

@prasunanand @Uditgulati Any updates on this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Uditgulati Uditgulati Awaiting requested review from Uditgulati

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add NMatrix serialization support

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pkspyder007 @prasunanand
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.