GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — RubyGrant 2020 related work by Uditgulati · Pull Request #57 · SciRuby/numruby

Conversation

@Uditgulati

@Uditgulati Uditgulati commented Mar 30, 2021

Copy link
Copy Markdown
Member
  • Added the nmatrix_buffer struct
  • Used buffer in slicing
  • Used TypedData_*_Struct
  • Fixed some warnings

The way buffer is used in slicing is that when slicing is called, instead of copying the elements into new nmatrix struct, a nmatrix_buffer struct is created and just the elements pointer to used to create the pointer of buffer matrix which removes the copying of elements and hence preventing a copy.

Also, nmatrix_buffer points to the original matrix and uses the original shape to create strides which are used in conjunction with buffer elements starting pointer to correctly access the sliced matrix elements from the original matrix elements array. This makes the sliced matrix as a view to the original matrix and one can change the sliced matrix elements and same change can be seen in the original matrix elements.

One can also create a view by doing a slice on a sliced matrix and internally the nmatrix_buffer would be created from nmatrix_buffer of given sliced matrix and the original matrix struct which is accessed from the given nmatrix_buffer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Uditgulati added 4 commits March 30, 2021 03:37
@Uditgulati
fix warnings
973178a
@Uditgulati
use TypedData_Get_Struct instead of Data_Get_Struct
693cbc6
@Uditgulati
add nmatrix_buffer struct
1f6ac41
@Uditgulati
add nmatrix buffer support to slicing
c6f6b0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Uditgulati
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.