GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add package of sapmachine-21 by Merlin-Xu-G · Pull Request #604 · ScoopInstaller/Java

Conversation

Merlin-Xu-G commented Jun 18, 2026

Copy link

Copy Markdown

Closes #603

[✅] I have read the Contributing Guide.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Merlin-Xu-G added 2 commits

June 18, 2026 10:51


          Add sapmachine21 JDK and JRE

8821a73


          Point the sapmachine LTS to sapmachine21

6c3ce48

coderabbitai Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2cdcfb3e-4c16-49fc-8122-75d7cefeea5a

📥 Commits

Reviewing files that changed from the base of the PR and between 6c3ce48 and bf2e771.

📒 Files selected for processing (1)

bucket/sapmachine21-jdk.json

💤 Files with no reviewable changes (1)

bucket/sapmachine21-jdk.json

Summary by CodeRabbit

New Features
- Added SapMachine 21 JDK and JRE distributions (version 21.0.11)
- Updated SapMachine LTS JDK and JRE to version 21.0.11

Walkthrough

The PR bumps the sapmachine-lts-jdk and sapmachine-lts-jre manifests from version 17.0.19 to 21.0.11, updating download URLs, SHA-256 hashes, extract directories, and checkver JSONPaths. It also adds two new version-pinned manifests, sapmachine21-jdk.json and sapmachine21-jre.json, each defining Windows x64 install metadata, environment wiring, and checkver/autoupdate rules.

Changes

SapMachine 21 Manifests

Layer / File(s)	Summary
LTS JDK and JRE version bump to 21.0.11 `bucket/sapmachine-lts-jdk.json`, `bucket/sapmachine-lts-jre.json`	Both LTS manifests replace version `17.0.19` with `21.0.11`, updating the Windows x64 download URL, SHA-256 hash, `extract_dir`, and `checkver` `jsonpath` to the `21` release asset path.
New sapmachine21 JDK and JRE manifests `bucket/sapmachine21-jdk.json`, `bucket/sapmachine21-jre.json`	Introduces version-pinned manifests for SapMachine 21.0.11, each specifying release metadata, Windows x64 artifact URL and hash, `extract_dir`, `env_add_path` for `bin`, `JAVA_HOME` via `env_set`, and `checkver`/`autoupdate` rules using upstream release JSON with JSONPath, regex capture, and SHA-256 file matching.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Add package of sapmachine-21' directly describes the main change: adding SapMachine 21 packages (both JDK and JRE) to the bucket.
Description check	✅ Passed	The description includes the required checkbox confirmation of reading the Contributing Guide and references the linked issue `#603` with 'Closes' keyword, meeting template requirements.
Linked Issues check	✅ Passed	The PR fully addresses issue `#603` by adding both sapmachine-jdk21 and sapmachine-jre21 bucket manifests with correct download URLs, SHA-256 hashes, and version checking configuration.
Out of Scope Changes check	✅ Passed	All changes are in-scope: updates to LTS versions (JDK/JRE 17→21) and addition of new SapMachine 21 packages directly address issue `#603` requirements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot reviewed

Jun 18, 2026

View reviewed changes

coderabbitai Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f5a798b9-e4fd-48ff-9907-2e2e25843fc3

📥 Commits

Reviewing files that changed from the base of the PR and between ca38e0d and 6c3ce48.

📒 Files selected for processing (4)

bucket/sapmachine-lts-jdk.json
bucket/sapmachine-lts-jre.json
bucket/sapmachine21-jdk .json
bucket/sapmachine21-jre.json

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

bucket/sapmachine21-jdk.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Merlin-Xu-G mentioned this pull request

Jun 18, 2026

[Request] Need a sapmachine-jdk21 package #603

Open


          Fix manifest file name

bf2e771

Reviewers

coderabbitai[bot]

coderabbitai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request] Need a sapmachine-jdk21 package

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Merlin-Xu-G commented Jun 18, 2026

Uh oh!

coderabbitai Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.