GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix #19, add test case by nicolaiunrein · Pull Request #20 · SimpleRegex/SRL-JavaScript

This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@nicolaiunrein

@nicolaiunrein nicolaiunrein commented May 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This PR fixes #19.
I Modified the clone method so that it also copies the fields _captureNames and _implodeString. If it does not make sense to add the _implodeString field feel free to remove it. I just looked at the code briefly in order to resolve #19 as I ran into the same problem myself and needed it to be fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nicolaiunrein
Fix SimpleRegex#19, add test case
a313f8e
@codecov-commenter

codecov-commenter commented May 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #20 (c5f640c) into master (79a8fd1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c5f640c differs from pull request most recent head a313f8e. Consider uploading reports for the commit a313f8e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   96.83%   96.84%   +0.01%     
==========================================
  Files          19       19              
  Lines         505      507       +2     
  Branches       73       73              
==========================================
+ Hits          489      491       +2     
  Misses         16       16
Impacted Files Coverage Δ
lib/Builder.js 97.08% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a8fd1...a313f8e. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nicolaiunrein
Fix #a313f8 as _implodeString should not be cloned.
ff2e2d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"_captureNames" is not saved in the internal Cache system

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nicolaiunrein @codecov-commenter
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.