GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Reuse one stream in codec benchmarks by JimBobSquarePants · Pull Request #3272 · SixLabors/ImageSharp Conversation
Member
Prerequisites
DescriptionThe codec benchmarks created a new Each changed benchmark now uses one stream for both libraries:
The results now measure the codec, not the growth of a new stream. Special cases:
I ran each changed benchmark and replaced the result table in its comment. These benchmarks already reused their stream, so I did not change them: This change touches only benchmark code, so it adds no tests. Changed files in
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsEach codec benchmark now reuses one MemoryStream for both libraries. Each call rewinds the stream, so the results measure the codec and not the growth of a new stream. EncodeTiff truncates the stream instead, because the GDI+ TIFF encoder fails on leftover bytes. Update the result tables from new runs. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |