GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(manifest): keep Maven components reachable from their root by jfblaa · Pull Request #1549 · SocketDev/socket-cli

Conversation

@jfblaa

@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) commented Sep 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

[agent]

Maven-generated manifests could mark a dependency as an "orphaned component not reachable from any direct dependency". Maven's conflict resolution can keep a dependency under a test or provided parent while its effective scope is compile; the extension then filed it under the prod root and dropped the edge that reached it.

Components are now assigned to the scope root they are actually reachable from, so nothing is emitted without a path from a direct dependency.

Added a shared reachability assertion to the Gradle, Maven and sbt compat smoke tests (unit-tested over synthetic records), plus a scope-conflict case in the Maven fixture. Verified the assertion fails against the pre-fix extension and passes after; the Gradle and sbt smoke suites pass locally.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jfblaa
fix(manifest): keep Maven components reachable from their root
7304c1b
Maven's conflict resolution can retain a dependency under a test or
provided parent while its effective scope is compile. The Maven facts
extension split each module's merged graph into prod and dev roots by
that effective scope and then dropped edges crossing the split, stranding
the node in a root with no parent edge. The manifest consumer reported
those nodes as orphaned components not reachable from any direct
dependency.

Assign root membership by reachability from each scope's direct
dependencies instead: a node reached from a compile/runtime/system
direct dependency stays in the prod root, and one reached only through a
test/provided parent lands in the dev root with its edge intact.

Add a shared reachability assertion to the Gradle, Maven and sbt compat
smoke tests, unit-tested over synthetic records, and cover the scope
conflict in the Maven fixture.
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) requested a review from Martin Torp (mtorp) September 22, 2026 07:52
cursor[bot]
cursor Bot reviewed Sep 22, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7304c1b. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/commands/manifest/scripts/test/assert-reachability.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jfblaa
docs(manifest): drop internal ticket id from test comments
eedcbe9
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) merged commit f800280 into v1.x Sep 22, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) deleted the jfblaa/rea-799-investigate-orphaned-components-in-maven-generated-manifest branch September 22, 2026 08:16
@scottames-github-bot scottames-github-bot Bot mentioned this pull request Sep 26, 2026
chore(deps): update ⬆️ vet-packages to v1.1.178 scottames/dots#1081
Merged
1 task
@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) mentioned this pull request Nov 12, 2026
fix(manifest): record every resolved Maven dependency edge #1711
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@mtorp Martin Torp (mtorp) Awaiting requested review from mtorp

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jfblaa
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.