GeezerVison is showing github.com — fix(manifest): keep Maven components reachable from their root by jfblaa · Pull Request #1549 · SocketDev/socket-cli
Conversation
[agent]
Maven-generated manifests could mark a dependency as an "orphaned component not reachable from any direct dependency". Maven's conflict resolution can keep a dependency under a test or provided parent while its effective scope is compile; the extension then filed it under the prod root and dropped the edge that reached it.
Components are now assigned to the scope root they are actually reachable from, so nothing is emitted without a path from a direct dependency.
Added a shared reachability assertion to the Gradle, Maven and sbt compat smoke tests (unit-tested over synthetic records), plus a scope-conflict case in the Maven fixture. Verified the assertion fails against the pre-fix extension and passes after; the Gradle and sbt smoke suites pass locally.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Maven's conflict resolution can retain a dependency under a test or
provided parent while its effective scope is compile. The Maven facts
extension split each module's merged graph into prod and dev roots by
that effective scope and then dropped edges crossing the split, stranding
the node in a root with no parent edge. The manifest consumer reported
those nodes as orphaned components not reachable from any direct
dependency.
Assign root membership by reachability from each scope's direct
dependencies instead: a node reached from a compile/runtime/system
direct dependency stays in the prod root, and one reached only through a
test/provided parent lands in the dev root with its edge intact.
Add a shared reachability assertion to the Gradle, Maven and sbt compat
smoke tests, unit-tested over synthetic records, and cover the scope
conflict in the Maven fixture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7304c1b. Configure here.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.