GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test(manifest): run the facts assembler over smoke-test records by jfblaa · Pull Request #1713 · SocketDev/socket-cli

Conversation

@jfblaa

@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

LLM Description written by Claude Code:claude-opus-5-5

Follow-up to #1711. The smoke tests' reachability check was a hand-ported copy of the assembler's own check. It rejected valid Maven records: a node whose scope dependencyManagement sets to compile under a test parent sits in Maven's compile root without a parent there, and its edge lives in the test root. The assembler merges a project's roots, so the facts were already correct.

What changes

  • The Gradle, Maven and sbt smoke tests assemble their records with the real parseRecords and assembleFacts, so the check cannot drift from the assembler. The assembler checks only the roots of known projects, so the runner also rejects a root of any other project.
  • assert-reachability.py and its unit tests are gone. Their shapes are now assembler tests.
  • The Maven fixture adds the managed-scope case: managed must be prod and its test parent dev.
  • The compat suites now need Node 22+ and installed dependencies, as the README says.

Test-only change. Compat matrices are green: Maven 3.2.5 to 4.0.0-rc-6, Gradle 1.12 to 9.2.1, sbt 0.13.18 to 1.9.9 (with Ivy).

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jfblaa
test(manifest): check Maven reachability per project, as the assemble…
c4a6824
…r does

A prod node whose scope dependencyManagement sets sits in Maven's compile
root without a parent there; its edge lives in the test root. The
assembler merges a project's roots, so the facts are fine, but the
shared reachability assertion rejected the Maven records. Maven's smoke
test now checks each project with --per-project, which merges a
project's roots the way the assembler does. Gradle and sbt keep the
stricter per-root check, as their roots are independent resolutions.

Both modes now drop an edge whose ends are not both nodes of its root,
as the assembler does, so a dangling edge no longer makes a node look
reachable. The Maven fixture covers the managed-scope case.
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) requested review from Oskar Haarklou Veileborg (BarrensZeppelin) and Martin Torp (mtorp) November 12, 2026 12:08
@cursor

cursor Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Low Risk
Test and assertion-script changes only; no production manifest assembly or extension runtime behavior is modified.

Overview
Fixes false failures in the shared manifest reachability smoke check for Maven records where a compile-root node’s parent edge only exists in the test root (notably dependencyManagement forcing compile scope under a test parent).

assert-reachability.py gains --per-project to merge a project’s resolution roots like the assembler, and both modes now ignore edges unless both endpoints are nodes in that root. The Maven compat smoke test calls --per-project; Gradle/sbt keep the per-root default.

The Maven fixture adds mgd-test → managed, with assert-records.py and unit tests covering prod/dev placement and the new reachability behavior.

Reviewed by Cursor Bugbot for commit c4a6824. Configure here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BarrensZeppelin
Oskar Haarklou Veileborg (BarrensZeppelin) reviewed Nov 12, 2026
View reviewed changes

@BarrensZeppelin Oskar Haarklou Veileborg (BarrensZeppelin) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[agent] Simplification review: report only, no correctness hunting. Inline comments below. Nothing to flag in assert-records.py or maven-compat-smoke-assertions.test.mts; the managed-scope additions follow the existing pattern and reuse edge_pair, in_prod and edge_roots.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/commands/manifest/scripts/test/assert-reachability.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/commands/manifest/scripts/test/assert-reachability.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/commands/manifest/scripts/test/assert-reachability.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/commands/manifest/scripts/test/assert-reachability.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/manifest-reachability-assertions.test.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/commands/manifest/scripts/test/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jfblaa
test(manifest): run the facts assembler over smoke-test records
a653c0f
assert-reachability.py was a hand-ported copy of the assembler's own
reachability check, and the per-project mode ported more of it. The
smoke tests now assemble the records with the real parseRecords and
assembleFacts, which throw on a resolved dependency no direct dependency
of its project reaches, so the check cannot drift from the assembler.
The assembler checks only the roots of known projects, so the runner
also rejects a root of any other project. The script, its unit tests
and the --per-project flag are gone; their shapes are now assembler
tests.
@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) changed the title test(manifest): check Maven reachability per project, as the assembler does test(manifest): run the facts assembler over smoke-test records Nov 12, 2026
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) requested a review from Oskar Haarklou Veileborg (BarrensZeppelin) November 12, 2026 13:01
BarrensZeppelin
Oskar Haarklou Veileborg (BarrensZeppelin) approved these changes Nov 12, 2026
View reviewed changes
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) merged commit bbd2fd2 into v1.x Nov 12, 2026
17 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) deleted the jfblaa/maven-reachability-per-project branch November 12, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BarrensZeppelin Oskar Haarklou Veileborg (BarrensZeppelin) BarrensZeppelin approved these changes
@mtorp Martin Torp (mtorp) Awaiting requested review from mtorp

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jfblaa @BarrensZeppelin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.