GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(manifest): give a Maven sibling's jar and test-jar their own ids by jfblaa · Pull Request #1716 · SocketDev/socket-cli

Conversation

@jfblaa

@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

LLM Description written by Claude Code:claude-opus-5-5

The Maven facts extension wrote a reactor sibling's jar and its test-jar under one bare groupId:artifactId:version id. So one record node mixed the two artifacts' scopes, directness and children, and the walk needed special cases for it. Each artifact now has its own coordinate and names the sibling module as its project. The assembler already merges a project's artifacts into its component, as it does for Gradle variants, so the facts are unchanged. On the compat fixture, socket manifest maven output is identical with the old and new extension.

The fixture now pins the per-artifact records:

  • In app, lib's jar is prod and not direct; it comes through mid.
  • lib's test-jar is direct and dev.
  • demo.ext:libdep hangs under the test-jar, not the jar, since mid excludes it from lib.

Maven compat matrix 3.2.5 to 4.0.0-rc-6 green. Suggested in the review of #1711.

Resolves REA-1165.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) requested review from Oskar Haarklou Veileborg (BarrensZeppelin) and Martin Torp (mtorp) November 12, 2026 12:27
@cursor

cursor Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes how internal Maven dependency nodes are keyed and linked in manifest records, which could affect reachability or component merging if the assembler assumptions are wrong; risk is mitigated by extensive compat smoke and synthetic record tests.

Overview
The Maven socket-facts extension no longer collapses a reactor sibling's jar and test-jar into one bare groupId:artifactId:version node. Each resolved artifact is emitted under its full typed coordinate (as for external deps), with the sibling module's project key on the node row so the assembler can merge artifacts into one component.

Graph walking in SocketFactsRecordsEngine drops the separate visited set and upsert path: deduplication is keyed by externalId, scope/directness/children attach per artifact, and SocketSupport.bareId is removed.

Maven compat fixtures and tests are updated to pin per-artifact behavior (e.g. lib's jar prod via mid, test-jar direct in app, demo.ext:libdep only under the test-jar, inter-module edges on artifact coordinates).

Reviewed by Cursor Bugbot for commit d55deef. Configure here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BarrensZeppelin
Oskar Haarklou Veileborg (BarrensZeppelin) approved these changes Nov 12, 2026
View reviewed changes
@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) mentioned this pull request Nov 12, 2026
fix(manifest): classify every Maven dependency scope as Maven does #1717
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) added 2 commits November 12, 2026 16:49
@jfblaa
refactor(manifest): give a Maven sibling's jar and test-jar their own…
56034b8 
… ids

The Maven facts extension wrote both a reactor sibling's jar and its
test-jar under one bare groupId:artifactId:version id, so one record node
mixed the two artifacts' scopes, directness and children, and the walk
needed special cases for it. Each artifact now has its own coordinate and
names the sibling module as its project; the assembler already merges a
project's artifacts into its component, as it does for Gradle variants,
so the facts are unchanged.

Resolves REA-1165.
@jfblaa
test(manifest): pin the Maven sibling artifacts to the module that us…
f6749d5 
…es them

Check that lib's jar is prod in app itself, not just in mid, and that
mid's edge reaches it there; check liba's jar both names liba and has no
file record. Read a coordinate's project without assuming a node row.
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) force-pushed the jfblaa/maven-sibling-artifact-ids branch from 62a940a to f6749d5 Compare November 12, 2026 15:53
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) merged commit bce3f0e into v1.x Nov 12, 2026
23 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) deleted the jfblaa/maven-sibling-artifact-ids branch November 12, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BarrensZeppelin Oskar Haarklou Veileborg (BarrensZeppelin) BarrensZeppelin approved these changes
@mtorp Martin Torp (mtorp) Awaiting requested review from mtorp

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jfblaa @BarrensZeppelin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.