GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(test): e2e_safety_pnpm — don't follow pnpm 10.34's store→project symlinks by mikolalysenko · Pull Request #126 · SocketDev/socket-patch Conversation
Collaborator
SummaryFixes the Root cause: pnpm ≥ 10.34 (the runner's floating The CoW defense was never broken. Inode forensics on failing fixtures show the real CAFS entry untouched: proj_b and the store still share the original inode (nlink 2) with original bytes, proj_a on a fresh private inode — exactly the invariant the test exists to prove. The sibling test ( Fix: the store walker skips symlinks ( TestingLinux container with pnpm 10.34.5 (the failing environment; reproduced red on first try before the fix): full 🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionspnpm >= 10.34 records every project the store has served as a symlink under <store>/v10/projects/<hash> -> ../../proj_x. The e2e_safety_pnpm walker followed those links back INTO the project trees, so find_store_file_with_content could return proj_a's own node_modules index.js — freshly patched — and misreport it as 'the store entry', tripping the store-must-stay-unpatched asserts. Whether it did depended on readdir order: deterministic-red on CI's ubuntu ext4 since the runner image picked up pnpm 10.34.5 (first failed on main at 70b41d6, a dep-bump-only commit), green on macOS/Windows. The real CAFS entry was verified untouched in every failing run (inode forensics: proj_b + store share the original inode, nlink 2, original bytes) — the CoW defense itself was never broken. Skipping symlinks is lossless: the store's real content (files/, index/) contains none. Verified in a Linux container with pnpm 10.34.5: red-first-try before the fix, 5/5 suite runs green after. Co-Authored-By: Claude Fable 5 <[email protected]>
Mikola Lysenko (mikolalysenko)
enabled auto-merge (squash)
Wenxin Jiang (Wenxin-Jiang)
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |