GeezerVison

LLM Description written by Claude Code:claude-opus-5-5

Fixes #896

Summary

A Bundler project reached through a symlinked directory (macOS /tmp →
/private/tmp, a symlinked workspace or volume on Linux) with
BUNDLE_GEMFILE=$PWD/Gemfile, or the same path in .bundle/config, is
now treated as the project's own Gemfile. Before, hosted scan redirected
nothing (redirect_gem_bundle_gemfile_unsupported), vendored mode
refused, vex exited 2 ("never installed") and rollback failed with
patched_ref_unattributable, all on a correctly configured project.

Root cause

formats::gem::manifest::classify (and with_lockfile, and the
env_keeps_root check inside classify) compared the configured path
with the project root lexically. Bundler expands the setting lexically and
then opens it through the OS, so a symlinked spelling of the directory
names the same file and the same Gemfile.lock.

Fix

• A configured path names a root file when its file name matches and its
  directory is the root's directory: lexically equal, or the same directory
  by file identity (same_file: device + inode on Unix, so a bind mount or
  Windows junction counts too). Only the directory is resolved, so a root
  Gemfile that itself links to a manifest elsewhere stays "another
  manifest" (Bundler's root, and its lock, follow the spelled directory).
• The same comparison applies to bundler 4's BUNDLE_LOCKFILE and to
  deciding whether an env BUNDLE_GEMFILE keeps Bundler's root (so the
  app config still outranks it).
• In-memory views (whose root / only stands in for a project not on this
  disk) use new lexical-only variants, so the host's directories never
  decide their verdict.
• Every caller (hosted gate, vendored gate, lock inventory, VEX discovery,
  rollback attribution) goes through classify, so all are fixed at once.

Tests (red → green)

Local runs on 0528f9f:

• cargo fmt --all -- --check: clean
• cargo clippy --workspace --all-features -- -D warnings: clean
• cargo test -p socket-patch-cli --all-features --test e2e_redirect_gem_build --test e2e_vendor_gem_build -- --ignored (Ruby 3.3.6, Bundler 4.0.18): 29 + 8 passed
• cargo test --workspace --all-features --no-fail-fast: all gem tests pass. 13 tests fail only in this sandbox and are unrelated: chmod-based write-failure tests (covgap_commands_vendor, in_process_redirect, repair, 4 core lib tests) because the sandbox runs as uid 0, and e2e_bun_lockb::binary_shared_bundled_record_hosted_pin_is_managed because patches-api.socket.dev is unreachable here. CI runs them as a normal user with network.

/code-review high findings

Fixed: in-memory views now compare lexically; directory identity uses
same_file instead of canonical path strings (covers bind mounts and
junctions) and is checked once per classify instead of per candidate.
Not changed:

• Snapshot views don't fingerprint the directory identity of a configured
  absolute path. A symlink retargeted between two passes of one run is far
  outside a real workflow; the comment now says so.
• hatch_env::same_path is a different (canonicalize) helper; this fix
  uses the crate's existing same_file dependency instead, so there is
  nothing to share.
• The module doc's "a missing file" wording predates this change (a missing
  root Gemfile named lexically was already Configured).

No wrapper (npm/, pypi/, gem/) changes: they only dispatch to the binary.

🤖 Generated with Claude Code

Generated by Claude Code