GeezerVison

LLM Description written by Claude Code:claude-opus-5-5

Fixes #1467

Summary

When a committed vendored artifact is missing or changed, vendor --check
now says what is wrong, names the file, and gives the step that fixes it.
Before, it printed the Rust Debug form of an internal state, with no path
and no remedy:

pkg:npm/[email protected]: artifact verification failed: Corrupt { reason: "vendor_workspace_artifact_missing" }

Now (Bun bun.lockb workspace, member copy deleted):

pkg:npm/[email protected]: Bun workspace copy packages/a/.socket/vendor/npm/<uuid>/minimist-1.2.2.tgz is missing (vendor_workspace_artifact_missing); the committed artifact .socket/vendor/npm/<uuid>/minimist-1.2.2.tgz it mirrors is intact; run `socket-patch repair` to restore it, then commit it

The same text goes into the --json event's reason. The stable tag
stays in parentheses so logs remain searchable.

Root cause

run_check in crates/socket-patch-cli/src/commands/vendor.rs turned every
non-healthy ArtifactHealth into format!("artifact verification failed: {health:?}").
That string is shared by every vendored ecosystem, so the root-artifact
rows in the issue (Missing, Corrupt { reason: "vendor_sha256_mismatch" })
were affected as well as the Bun member-copy rows.

Fix

• New vendor::describe_artifact_failure in core. It turns each health
  state into a cause, the committed path, and the remedy that matches what
  repair does for that state:
  • missing or corrupt: socket-patch repair, then commit. When repair
    would refuse because the ledger has no archive SHA-256 (file artifact)
    or no file inventory (directory artifact), the message gives repair's
    own refusal and remedy instead (shared redownload::ledger_blocks_restore).
    For a JVM entry, "missing" also covers a missing tree marker.
  • Bun member copy: names the member path (bun_workspace::failing_mirror).
    It calls the root artifact intact only when the ledger records its
    sha256.
  • pending re-vendor (vendor_uuid_mismatch): socket-patch vendor.
  • unverifiable: says repair won't rebuild it. When the Bun workspace
    copies can't be listed, the message carries the real cause; other cases
    point at the ledger, the manifest, or a re-vendor.
  • unknown npm flavor: upgrade socket-patch.
• ArtifactHealth::is_workspace_copy_issue() replaces repair's private
  copy of the same check, so vendor --check and repair agree on what
  counts as a member-copy failure.
• No wrapper changes are needed: npm/, pypi/, and gem/ only
  dispatch to the binary and never parse this text.

Tests (red → green)

Without the fix (the CLI change reverted), the CLI test fails:

left: String("artifact verification failed: Corrupt { reason: \"vendor_sha256_mismatch\" }")
right: "committed artifact .socket/vendor/npm/<uuid>/left-pad-1.3.0.tgz does not match the sha256 in the vendor ledger (vendor_sha256_mismatch); run `socket-patch repair` to restore it, then commit it"

With the fix, it passes. Commands run locally:

• cargo fmt --all -- --check: clean
• cargo clippy --workspace --all-features -- -D warnings: clean
• cargo test -p socket-patch-core --all-features --lib -- vendor::: everything passes except two chmod-based write-failure tests (pypi_poetry::wire_write_failure_*, pypi_requirements::wire_failure_rolls_back_*). Those tests can't make a write fail when run as root, which is how this sandbox runs. They are unrelated to this change, and CI runs as a non-root user.
• cargo test --workspace --all-features: this sandbox's disk allowance cannot hold every test binary (it fails with ENOSPC while linking), so I ran the suites this change touches instead. in_process_vendor: 133/133 pass. repair: 126 pass; the 2 failures are chmod-based tests (*_unremovable, repair_cleanup_failure_*). covgap_commands_vendor: 54 pass; the 3 failures are chmod-based *_state_write_failure_* tests. A root user ignores those permissions, which is why they fail here. CI runs the full workspace.

Bugbot

Two findings on c8c77bf. Both were real, both are fixed in c8cec59, and
both threads are answered and resolved: repair advice where repair would
refuse, and the wrong cause given for vendor_workspace_artifact_invalid.

Code review (/code-review high)

Fixed: the "intact" claim without a recorded sha256, the one-size remedy
for unverifiable entries, the StaleUuid wording, the JVM marker case, the
duplicated workspace-copy check, and the test doc.

Not fixed:

• failing_mirror re-reads the mirrors to find the path, which costs I/O
  and allows a re-check race. It runs only after a check has already
  failed, and vendor --check is a read-only audit. Carrying the path in
  ArtifactHealth::Corrupt would change a public enum that about ten
  match sites use.
• repair keeps its own StaleUuid and UnknownFlavor wording. Changing repair's
  output is out of scope here.

Generated by Claude Code