GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix phantom version bump in release-readiness by mikolalysenko · Pull Request #1497 · SocketDev/socket-patch

Conversation

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026 •

edited by cursor Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Problem

release-readiness failed falsely on PR #1489 after it merged main across the 5.0.1 release (run 38444545888):

Version bump PR detected (5.0.0 -> 5.0.1); running the full release gate.
##[error]tag v5.0.1 already exists at 2e0a6b9e... — bump to a new version

The PR didn't bump anything. The event's pull_request.base.sha was 285a5e8 (main before the release, 5.0.0), but the tested merge commit c59161a was "Merge 36b49c6 into d4af25a" (current main, 5.0.1). That turned ci-ok red for a version bump that wasn't real. The next push went green. The same thing can happen to any open PR that merges main after a release lands while the event payload's base lags.

Root cause

github.event.pull_request.base.sha isn't guaranteed to be the commit refs/pull/N/merge was built on. It can lag behind the base branch.

Fix

Read the base from the first parent of the checked-out merge commit (git cat-file -p HEAD, which works in the depth-1 checkout) and drop the BASE_SHA env. That parent is exactly the base the tested tree was merged onto. Real version-bump PRs (release/v*) still see main's old version as the parent and run --tag-check. The release-sync path is unchanged.

Proof

Local repro: built a merge ref whose base had moved, fetched it with --depth 1 as actions/checkout does, and the parsed first parent matched the moved base tip, which then fetched by SHA.
On Fix scans missing renamed yarn copies (#939, #1236) #1489's failing run, the first parent is d4af25a (5.0.1). That means no bump, so it runs --sync-only, which is what the following green run did.
YAML parses. actionlint and zizmor aren't available in this sandbox.

Where tests run

Nothing removed or moved. Job and check names are unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LgS1BwdcQfkDYXqbXL8uUA

Generated by Claude Code

Note

Low Risk
CI-only change to how the release-readiness gate picks the base commit; no runtime or release publish behavior changes.

Overview
Fixes false version-bump failures in the release-readiness CI job when a PR merges main after a release lands.

The job used github.event.pull_request.base.sha to read the base Cargo.toml version, but that SHA can lag behind the commit refs/pull/N/merge was actually built on. That made merges-across-release look like 5.0.0 → 5.0.1 bumps and triggered --tag-check even though the PR did not change the version.

Change: drop the BASE_SHA workflow env and set it from the first parent of HEAD (the checked-out merge commit) via git cat-file, then fetch that object for the version comparison. Real bump PRs and the release-sync path are unchanged.

^{Reviewed by Cursor Bugbot for commit 64211d4. Configure here.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Use merge parent as base in release-readiness

64211d4

github.event.pull_request.base.sha can lag behind the main commit
that refs/pull/N/merge was actually built on. When a PR merges main
across a release, the stale base still carries the old version, so
the job sees a phantom version bump, runs --tag-check and fails
because the new tag already exists (PR #1489, run 38444545888:
base 285a5e8 at 5.0.0, merge built on d4af25a at 5.0.1).

Read the base from the first parent of the checked-out merge commit
instead; that is exactly the base the tested tree was merged onto.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01LgS1BwdcQfkDYXqbXL8uUA

Mikola Lysenko (mikolalysenko) added the ci-janitor Opened by the CI janitor routine (flakes, redundant tests, CI perf) label

Oct 13, 2026

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Copy link

Copy Markdown

Collaborator Author

bugbot run

Generated by Claude Code

cursor[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot reviewed

Oct 13, 2026

View reviewed changes

cursor Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 64211d4. Configure here.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Tanmay Singla (Tanmay182003) approved these changes

Oct 13, 2026

View reviewed changes

Mikola Lysenko (mikolalysenko) mentioned this pull request

Oct 13, 2026

Swarm health manager log #1382

Open

Mikola Lysenko (mikolalysenko) added this pull request to the merge queue

Oct 13, 2026

Merged via the queue into main with commit aa85c6c

Oct 13, 2026

55 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Mikola Lysenko (mikolalysenko) deleted the ci-janitor/release-readiness-merge-base branch

October 13, 2026 19:59

Mikola Lysenko (mikolalysenko) mentioned this pull request

Oct 14, 2026

CI performance dashboard #1182

Open

Reviewers

cursor[bot]

cursor[bot] left review comments

Tanmay Singla (Tanmay182003)

Tanmay182003 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ci-janitor

Opened by the CI janitor routine (flakes, redundant tests, CI perf)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root cause

Fix

Proof

Where tests run

Uh oh!

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mikola Lysenko (mikolalysenko) commented Oct 13, 2026 •

edited by cursor Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.