GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: stop counting docker-e2e/setup-e2e soft-skips as passing tests by mikolalysenko · Pull Request #151 · SocketDev/socket-patch

Conversation

@mikolalysenko

@mikolalysenko Mikola Lysenko (mikolalysenko) commented Aug 10, 2026 •
edited by cursor Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Summary

Stacked on #150 (base = fix/sweep-bugfixes-and-test-harness; retarget to main once that lands).

The test (3-OS matrix) and test-release jobs run cargo test --workspace --all-features, which also executes the feature-gated docker_e2e_* / setup_matrix_* suites. In these jobs they always soft-skip — no test images are built there, and macOS/Windows have no Docker — but each skip reports as a passing test. That inflates the green count by dozens per OS leg, and a regressed skip-guard could silently disable a real suite while CI stayed green.

Fix: build with --all-features --no-run (keeps compile-rot coverage for the gated suites), run with default features only. The gated suites keep executing for real in the dedicated e2e-docker and setup-matrix jobs.

Verification

  • YAML validated.
  • No test-selection change for default-feature suites; the only delta is that soft-skipping gated tests no longer appear in the run counts.

🤖 Generated with Claude Code

Note

Low Risk
Workflow-only test invocation change; default-feature test coverage is unchanged and gated suites still run in dedicated jobs.

Overview
The test (3-OS) and test-release jobs no longer run cargo test with --all-features. They now compile the full workspace with --all-features --no-run (still catching compile rot in feature-gated suites), then execute tests with default features only.

That stops docker_e2e_* / setup_matrix_* from running in those jobs and reporting dozens of soft-skip “ok” results where Docker/images are absent—so a broken skip guard can’t keep CI green. Real execution of those suites stays in e2e-docker and setup-matrix.

Both steps use bash with set -euo pipefail on the matrix test job.

Reviewed by Cursor Bugbot for commit b5513b4. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mikolalysenko @claude
ci: stop counting docker-e2e/setup-e2e soft-skips as passing tests
b5513b4 
The test and test-release jobs ran `cargo test --workspace
--all-features`, which also RUNS the feature-gated docker-e2e and
setup-e2e suites. Those tests soft-skip as "ok" when no
socket-patch-test images exist — which is always true in these jobs (no
images are built there; macOS/Windows have no Docker at all). Every OS
leg therefore reported dozens of fake green tests, and a broken
skip-guard would disable a whole suite while CI stayed green.

Split build from run: --all-features --no-run keeps the compile-rot
coverage for the gated suites, the run step uses default features only.
The dedicated e2e-docker and setup-matrix jobs remain the places where
the gated suites actually execute.

Co-Authored-By: Claude Fable 5 <[email protected]>
@mikolalysenko Mikola Lysenko (mikolalysenko) mentioned this pull request Aug 10, 2026
Structure-review batch: sweep fixes, module taxonomy, npm-family dedup, coverage gaps, CI honesty #150
Merged
@mikolalysenko

Mikola Lysenko (mikolalysenko) commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator Author

Folded into #150 — the stack was consolidated into a single PR at the author's request; this PR's commit is included there verbatim (cherry-picked, all tests green on the consolidated head).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mikolalysenko Mikola Lysenko (mikolalysenko) closed this Aug 10, 2026
@mikolalysenko
Mikola Lysenko (mikolalysenko) deleted the ci/test-job-honesty branch August 10, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@mikolalysenko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.