GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix nightly old-uv orphan-unwind failure in uv e2e by mikolalysenko · Pull Request #1525 · SocketDev/socket-patch

Conversation

@mikolalysenko

@mikolalysenko Mikola Lysenko (mikolalysenko) commented Oct 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Problem

The nightly CI run on main failed today (run 38518420487). The suite failed in 4 of the 12 e2e-full (ubuntu-latest, e2e_redirect_uv_build, <uv>) legs: uv 0.2.37, 0.3.5, 0.4.30, 0.5.3. The 0.5.6 through 0.12.17 legs passed. Yesterday's nightly at 15c2c83 was green. Each failing leg failed in the same test and at the same assertion:

hosted_uv_transitive_override_manifestless_vex panicked at tests/vex_e2e_common/uv.rs:1986:
uv 0.5.3 hosted transitive [orphan-unwind]: uv.lock still wires six:
[manifest]
overrides = [{ name = "six", specifier = "==1.17.0" }]

The orphan-unwind step came in with #1453 (#1445), which landed after yesterday's nightly. The suite runs --ignored, so these old-uv legs only run nightly, and #1453's PR checks never ran them.

Root cause

uv before 0.5.6 records the override-dependencies pin that the hosted rewrite adds as a bare { name, specifier = "==<version>" } in [manifest] overrides, without folding in the [tool.uv.sources] url. restore_requirement_array only dropped a rewrite-owned overrides record when it carried the hosted url, so retiring an orphaned pin removed the pyproject lines but left the lock record behind. This is a product bug as well as a red nightly: on old uv, rollback leaves a lock that no longer matches pyproject.toml.

Fix

In [manifest] overrides, when the metadata holds the rewrite's marked pin for the package (transitive_override), also drop a url-less, marker-less record whose specifier is exactly ==<version>. A user's own unmarked pin still keeps its record (#411). That case is covered by the new unit test bare_manifest_override_of_the_rewrite_is_dropped.

Proof

  • Reproduced locally with uv 0.5.3 (cargo test -p socket-patch-cli --test e2e_redirect_uv_build -- --ignored): same panic.
  • After the fix, the full ignored suite passes 9/9 on uv 0.2.37, 0.5.3 and 0.11.32.
  • cargo test -p socket-patch-core --lib upstream::uv passes 25/25. --test hosted_inventory passes 21/21. socket-patch-cli --test in_process_rollback_hosted passes 41/41.
  • cargo clippy -p socket-patch-core --all-targets -- -D warnings reports the same 33 test-code lints with and without this change. All of them are already on main, and none is in the new code.

No tests were removed or moved.

🤖 Generated with Claude Code

https://claude.ai/code/session_012v7idpMckM6PU5mBKBBmmg


Generated by Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@claude
Retire bare uv manifest overrides of old uv
55902cd
The nightly e2e-full legs of e2e_redirect_uv_build for uv 0.2.37,
0.3.5, 0.4.30 and 0.5.3 fail since #1453 added the orphan-unwind
step: after rollback retires a leftover hosted override, uv.lock still
holds `[manifest] overrides = [{ name = "six", specifier = "==1.17.0" }]`.

uv before 0.5.6 records the override the hosted rewrite adds without
folding in its [tool.uv.sources] url, and the restore only dropped
records that carry the hosted url. Drop the bare `==<version>` record
of the pin under the rewrite's ownership mark too; a user's own
unmarked pin keeps its record (#411).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_012v7idpMckM6PU5mBKBBmmg
@mikolalysenko Mikola Lysenko (mikolalysenko) added the ci-janitor Opened by the CI janitor routine (flakes, redundant tests, CI perf) label Oct 14, 2026
@mikolalysenko

Mikola Lysenko (mikolalysenko) commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

bugbot run


Generated by Claude Code

cursor[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor[bot]
cursor Bot reviewed Oct 14, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 55902cd. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Tanmay182003
Tanmay Singla (Tanmay182003) approved these changes Oct 14, 2026
View reviewed changes
@mikolalysenko Mikola Lysenko (mikolalysenko) mentioned this pull request Oct 14, 2026
Swarm health manager log #1382
Open
@mikolalysenko Mikola Lysenko (mikolalysenko) added the Ready for review Agent-verified: mergeable, CI green, Bugbot clean — awaiting human review label Oct 14, 2026
@mikolalysenko

Mikola Lysenko (mikolalysenko) commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

Labeled Ready for review by the burn-down agent.

  • Head: 55902cd6f7505c4ca609bd26610ebb525512e58b
  • CI: 54/54 check runs completed, all success or skipped (ci-ok green); no main-wide failures
  • Bugbot: reviewed this head, no findings
  • Mergeable: clean; one approval already on this head (Tanmay182003)
  • Reviewer focus: the new bare-override drop in restore_requirement_array (crates/socket-patch-core/src/patch/redirect/upstream/uv.rs). It only fires when the metadata holds the rewrite's marked transitive_override pin, so a user's own unmarked ==<version> pin keeps its lock record (Hosted uv rollback and remove delete a user-authored override-dependencies = ["<pkg>==<ver>"] pin that hosted mode never added #411).

Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mikolalysenko Mikola Lysenko (mikolalysenko) mentioned this pull request Oct 14, 2026
CI performance dashboard #1182
Open
@mikolalysenko
Mikola Lysenko (mikolalysenko) added this pull request to the merge queue Oct 14, 2026
@mikolalysenko Mikola Lysenko (mikolalysenko) mentioned this pull request Oct 14, 2026
Spawn every CLI test child through one hermetic Command builder; 10 test files inherit ambient SOCKET_* today #823
Closed
5 tasks
Merged via the queue into main with commit 4a29912 Oct 14, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mikolalysenko
Mikola Lysenko (mikolalysenko) deleted the ci-janitor/uv-bare-manifest-override branch October 14, 2026 09:01
This was referenced Oct 14, 2026
CI perf (settings): slow Depot 16-core hosts since 10-13 15:20 add ~1.5–2.5 min to the merge-queue critical path (~0.6k Linux job-min/day) #1512
Open
CI perf: floating toolchain versions in ci.yml e2e — upstream uv 0.13.2 red-mained the merge queue for 2.7 h (~4.3k job-min wasted on 10-20; ~0.45k min/day amortized) #1645
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@Tanmay182003 Tanmay Singla (Tanmay182003) Tanmay182003 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ci-janitor Opened by the CI janitor routine (flakes, redundant tests, CI perf) Ready for review Agent-verified: mergeable, CI green, Bugbot clean — awaiting human review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mikolalysenko @Tanmay182003 @claude
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.