GeezerVison

LLM Description written by Claude Code:claude-opus-5-5

Refs #1089 (child 1, the #1090 scope: remove/covgap_commands_remove.rs)

Problem

The remove failure-path suite pinned whole English sentences in its
--json tests and kept private copies of the envelope readers that
tests/common/envelope.rs (#1272) provides. A copy edit to a remove
message broke these tests even when the exit code, error.code,
events and bytes on disk didn't change.

Change (test-only, 4 files)

• --json tests read the envelope through common::envelope and
  assert error.code, events, summary counts and on-disk state. They
  read the message only for what it must name: a purl, a flag, a path,
  the git checkout -- remedy, the "manifest was not modified"
  promise, or the short phrase that tells two causes apart when they
  share one code (restored lockfiles for the write failure, the
  Error during rollback: prefix for the rollback Err branch).
• Dropped: the exact lock_held message pin (the code is checked, and
  e2e_safety_lock owns that contract), and the sentence halves of the
  ledger, flavor, 404 and offline checks.
• Human-mode tests stay as the render checks. Each keeps one assertion
  per message family. The "Removed 1 patch from manifest:" lines are
  gone where the manifest is already checked on disk, and the mixed
  drift-keep human test now checks the manifest itself.
• common::envelope gains event_purls and has_event, with
  self-tests and ratchet entries. The file leaves
  PENDING_PRIVATE_READERS.
• Renamed to remove/remove_failure_paths.rs (no tests deleted, so
  commands/remove.rs coverage can't drop).

4+-word .contains("…") assertions in the file: 24 → 13. 11 are in
human-mode render tests. The 2 in --json legs are the vendor
"manifest was not modified" promise and the git checkout -- remedy. #1089's per-file target (≤3) needs the render suite from child 6,
so this PR says Refs, not Fixes.

Evidence

• cargo fmt --all -- --check passes.
• cargo test -p socket-patch-cli --all-features --test remove:
  100 passed. As root the 4 chmod tests skip, so I also ran the suite
  binary as nobody: remove_failure_paths 38 passed, with the
  read-only-dir legs executing (no skipping: lines).
• cargo test … --test cli -- envelope_helper: 11 passed (ratchet and
  helper self-tests).
• cargo clippy -p socket-patch-cli --all-features --test remove --test cli -- -D warnings: only the pre-existing duplicate-module
  lints in common/mod.rs and prebuilt_common/mod.rs; nothing in the
  changed files.
• Refactor only, so there is no red→green test.

CI cost

Test-only, no workflow changes. A lean PR run keeps the same job count
and minutes (about 28 Linux jobs, ~8 min wall), before and after.

Review notes (/code-review high)

Fixed: has_event moved into common::envelope; the git checkout --
remedy and the vendor "manifest was not modified" promise are checked
again; the mixed human test checks the manifest; the --json stderr
check looks for a Note: line, not the note's wording; dropped the
events shadowing; event_purls self-test covers non-string purls;
no throwaway String in the warning checks.
Not changed, by design: the Error during rollback: prefix and the
restored lockfiles phrase stay. They're the only thing that tells
two causes with the same error.code apart, and the module doc now
says so.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KroheaumCd65y9D9wJ9LKS

Generated by Claude Code