GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — CI: scan suite covgap files get real homes (#1089) by mikolalysenko · Pull Request #1583 · SocketDev/socket-patch Conversation
|
| Old | New |
|---|---|
scan/covgap_ecosystem_dispatch.rs (deno apply + rollback dispatch, adapted copies of another file's oracles) |
ecosystem_dispatch_e2e.rs::dispatch_branch_deno / rollback_dispatch_branch_deno, using that file's shared oracles. RollbackFixture.global: bool becomes scope_args so deno can pass --global-prefix |
scan/covgap_commands_fetch_stage.rs offline no-local-source report |
apply/apply_render.rs: one render check (header total, five distinct purls listed, ... and N more, repair remedy). The existing --json test in apply_silent_staging_errors.rs now also checks the offline_missing_sources warning code (no CLI test asserted it before), applied == 0, and an unchanged manifest and .socket/blobs |
scan/covgap_commands_fetch_stage.rs cold-cache online apply |
The fetch behavior (blob-only requests, applied, nothing in .socket/blobs) is already in apply/apply_network.rs. What stays is one render check in apply_render.rs: the result line on stderr, no permanent progress, nothing on stdout |
scan/coverage_fix_scan_discovery_corrupt_ledger.rs |
scan/scan_prune_corrupt_vendor_ledger.rs (already --json; now parses through common::envelope) |
scan/covgap_commands_scan_vendor_flow.rs |
scan/scan_vendor_flow.rs (already --json; every envelope now parses through common::envelope) |
apply_fixture.rs gets one shared write_sourceless_npm_patches(root, n), which replaces apply_silent_staging_errors.rs's private copy. No product code changes.
CI cost: test-only. A lean PR run is unchanged: about 28 Linux jobs and ~8 min, before and after, with no new test binary. Six moved tests become six checks, plus stronger assertions on one existing test. All are local or wiremock and take under a second each.
Test evidence
cargo test -p socket-patch-cli --all-features --test scan --test apply --test ecosystem_dispatch_e2e: 241 + 148 (1 ignored, pre-existing) + 43 passed, three runs in a row.cargo fmt --all -- --checkandcargo clippy --locked --workspace --all-features -- -D warningsare clean. Clippy with--testson these three binaries reports 33 lints both before and after this PR. They are pre-existing (file is loaded as a module multiple times, …) and none is in a line this PR adds.- CI on 1e87433: all 86 checks finished with no failures, and
ci-okpassed. Bugbot found no issues. - This PR moves tests, so there is no red→green regression test.
/code-review high findings
All seven fixed in 1e87433:
- The vacuous
node_modules/miss-0check is gone. The offline bail now checks the manifest bytes and.socket/blobs. - The duplicate
--jsonoffline test was dropped. Its new assertions moved into the existingapply_json_offline_missing_source_keeps_stderr_clean. That test's warnings check is "containsoffline_missing_sources, notsources_download_failed", not exact equality. - There is now one sourceless-manifest fixture, and it returns
(). The render check matches listed lines against the fixture purls. The order isn't pinned because the report lists purls in hash order. scan_vendor_flow.rs::assert_vendor_step_errorusesparse_json_envelope. The deno apply runner takes(String, String)env, likerun_rollback.
🤖 Generated with Claude Code
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
The scan test binary still carried four coverage-gap files, two of which tested other commands: - covgap_ecosystem_dispatch.rs held the deno apply and rollback dispatch checks as adapted copies of ecosystem_dispatch_e2e.rs's oracles. They now live in that file and use its shared oracles; RollbackFixture takes scope flags so the deno case can pass --global-prefix. - covgap_commands_fetch_stage.rs drove apply's staging output. Its cold-cache fetch duplicated apply_network.rs, so what stays is one render check per message family in apply_render.rs (the offline no-local-source report, the download result line) plus a new --json check in apply_failure_paths.rs that the offline bail reports the offline_missing_sources warning code, which no CLI test asserted before. - coverage_fix_scan_discovery_corrupt_ledger.rs and covgap_commands_scan_vendor_flow.rs already asserted through --json; they are renamed scan_prune_corrupt_vendor_ledger.rs and scan_vendor_flow.rs and parse through common::envelope. Test-only; no production change and no new test binary. Refs #1089 Assisted-by: Claude Code:claude-opus-5-5
- The offline --json bail already had a test in apply_silent_staging_errors.rs, so the new copy is dropped and that test now also checks the offline_missing_sources warning code, that nothing is applied, and that the manifest and .socket/blobs are left as they were. - That file's private sourceless-manifest writer is replaced by the shared write_sourceless_npm_patches fixture. - The offline report lists purls in no fixed order, so the render check counts five distinct fixture purls instead of a prefix match. - scan_vendor_flow.rs parses every envelope through common::envelope, and the deno apply runner takes env as (String, String) like the rollback runner. Refs #1089 Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1e87433. Configure here.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
Projects
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
3 participants
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.