GeezerVison

Problem

test-release (2) failed in the full-scope run 39745825228 (job 119714465566). That run made ci-ok red for #1663's head. The failing test was cargo_hosted_refuses_a_lockless_project_with_other_dependencies, and the message gave no cause:

panicked at crates/socket-patch-cli/tests/e2e_redirect_cargo_shapes.rs:977:9:
cannot lock [email protected]:
<the generated Cargo.lock, with cfg-if 1.0.5>

The project has no lockfile, so generate-lockfile resolves the newest cfg-if (1.0.5). pin_patched_versions then runs cargo update -p [email protected] --precise 1.0.4. That command returned non-zero, but its stderr was dropped. The pin works fine locally, and the full suite passes (33/33). So the likely cause is a transient index fetch in the fresh CARGO_HOME, the same blip class as #1459 and #1654. The log can't confirm it.

The same suite runs in coverage, which gates ci-ok and the merge queue. There, one such blip during fixture setup evicts the queue entry.

Root cause

Fixture setup already soft-skips when cargo can't reach crates.io: a failed generate-lockfile and a failed baseline cargo build both go through cargo_e2e_matrix::skip. The --precise pin is the same kind of network-dependent setup step, but it hard-asserted and dropped cargo's error.

Fix

pin_patched_versions now returns Err carrying each failed cargo update's stderr, and run_shape passes that to cargo_e2e_matrix::skip:

• Optional legs (coverage, test-release) skip, with the cause printed.
• The required lock-v* legs (SOCKET_PATCH_CARGO_E2E_REQUIRED=1, ci.yml:2397-2410, which run this suite) still fail on it. The panic now includes cargo's error.

This complements #1654, which widens CARGO_NET_RETRY under CI. That change makes blips rarer; this one makes a remaining blip skip on optional legs and makes any failure readable. The two PRs touch different files.

Proof

• cargo test -p socket-patch-cli --test e2e_redirect_cargo_shapes: 33 passed.
• A cargo shim on PATH that fails only update with a simulated download error:
  • Optional mode: SKIP e2e_redirect_cargo_shapes (lockless-other-dependencies): cannot lock [email protected] (crates.io unreachable?): \cargo update -p [email protected]`: error: failed to download ... (simulated blip)`, and the test passes as a skip.
  • SOCKET_PATCH_CARGO_E2E_REQUIRED=1: the test panics with the same text plus (and SOCKET_PATCH_CARGO_E2E_REQUIRED is set, so this leg must not skip).
• rustfmt was run on the touched file. cargo clippy -p socket-patch-cli --test e2e_redirect_cargo_shapes -- -D warnings is clean.

No tests were removed or moved. Every shape still runs everywhere it ran before.

https://claude.ai/code/session_01WKXDFSSDxDgdAGiUGLKWQB

Generated by Claude Code