GeezerVison is showing github.com — Give the CI test job 50 minutes so Windows can finish by mikolalysenko · Pull Request #278 · SocketDev/socket-patch
Conversation
The test job's Windows leg keeps hitting its 35-minute limit with every test passing, so this raises the limit to 50 minutes.
Why
- Green runs leave little headroom: Windows test runs today took 25–32 minutes.
- Slow runners cross the limit: on slower runners, the build step alone ran 4–5 minutes longer than usual. That pushed the job past 35 minutes before the last test binary (core unit tests, about 3 minutes) could finish.
- Recent timeouts:
Change
.github/workflows/ci.yml, test job: timeout-minutes: 35 → 50. It's the only change.- Nothing else pins this value.
- Linux and macOS are unaffected in practice, because they finish well under the limit.
🤖 Generated with Claude Code
Note
Low Risk
Workflow-only timeout tweak; no application or test logic changes.
Overview
Raises the test job timeout in .github/workflows/ci.yml from 35 to 50 minutes for the ubuntu / macOS / Windows matrix.
This targets Windows legs that were hitting the limit with all tests passing—often after slower builds left no time for the last binaries—without changing test steps or other jobs.
Reviewed by Cursor Bugbot for commit e63816a. Configure here.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Windows test runs today took 25-32 minutes when green, and slower runners
cut off three #270 runs and a release/v5-prerelease run at the 35-minute
limit with every test still passing. The build step alone ran 4-5 minutes
longer than usual, which left no headroom.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.