GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — Fix global scan missing pipx venvs (#415) by mikolalysenko · Pull Request #418 · SocketDev/socket-patch Conversation
|
| Test | Layout | Platforms |
|---|---|---|
..._discovers_pipx_venvs_linux |
~/.local/share/pipx/venvs/{hatch,black} |
Linux |
..._discovers_pipx_venvs_under_xdg_data_home |
$XDG_DATA_HOME/pipx/venvs/hatch |
Linux |
..._discovers_pipx_venv_lib64 |
venvs/hatch/lib64/python3.11/site-packages |
Unix |
..._discovers_pipx_venvs_legacy_home |
~/.local/pipx/venvs/hatch |
Unix |
..._discovers_pipx_venvs_macos_app_support |
~/Library/Application Support/pipx |
macOS |
..._discovers_pipx_venvs_windows |
%USERPROFILE%\pipx\venvs\hatch\Lib\site-packages |
Windows |
..._discovers_pipx_venvs_under_pipx_home |
$PIPX_HOME/venvs/hatch (path with a space) |
all |
cargo test -p socket-patch-core --all-features --test crawler_python_e2e pipx gave 5 failed, 0 passed.crawler_python_e2e gave 47 passed, 0 failed.pipx==1.7.1 install pycowsay under a scratch HOME, then scan -g --json --ecosystems pypi. scannedPackages was 42 on main and is 43 with this branch (the pipx venv's package).cargo clippy --workspace --all-features -- -D warnings is clean. The added code is rustfmt-clean. cargo fmt --all -- --check isn't clean on main itself, and CI doesn't run it, so this PR leaves the rest of the workspace alone.cargo test --workspace --all-features --no-fail-fast: everything passes except 16 write-failure tests in covgap_commands_vendor, in_process_redirect, repair and core --lib. They simulate write failures with chmod 0o555, which the root-run sandbox bypasses, and none of them touch the code changed here. They pass in CI, which runs as non-root.d391f14: all 6 workflows that ran are green (CI, Audit GHA Workflows, npm, pnpm, Pipenv, vlt). Bugbot reviewed d391f14 and found no issues.PIPX_HOME (all of the tests above).Generated by Claude Code
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Assisted-by: Claude Code:claude-opus-5-5
scan -g, apply -g, rollback -g and vex -g never looked inside pipx's per-app venvs, so the dependencies of a pipx-installed tool such as Hatch were never reported or patched on any OS. Global discovery now scans <pipx home>/venvs/* under PIPX_HOME and every pipx default home. Fixes #415 Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
The previous commit ran rustfmt over the whole workspace, which reformatted 126 files the fix doesn't touch. Restore them to main so the PR only carries the pipx discovery change and its tests. Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d391f14. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
[burn-down agent] Ready for review on
Generated by Claude Code |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Global scan (-g) never crawls pipx venvs, so the dependencies of a pipx-installed Hatch are never reported, patched or rolled back on any OS
There was an error while loading. Please reload this page.