GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix: add apply diagnostics for silent no-op failures by Wenxin-Jiang · Pull Request #53 · SocketDev/socket-patch Conversation
Contributor
Summary
Addresses findings CRITICAL-1 (zero packages → exit 0), CRITICAL-2 (version mismatch → silent skip), and CRITICAL-3 (no unmatched-manifest diagnostic) from the reliability audit. Test plan
🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsWhen `apply` runs in CI and no packages match manifest patches, it previously exited 0 silently, masking configuration errors. This change: - Tracks which manifest entries actually matched installed packages - Returns exit code 1 when targeted patches exist but nothing matched - Emits per-PURL warnings for unmatched manifest entries - Adds a post-apply summary (applied/already-patched/not-found counts) - Includes `unmatchedPatches` and `unmatchedPurls` in JSON output - Changes `apply_patches_inner` signature to return unmatched PURLs Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Mikola Lysenko (mikolalysenko)
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |