GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: add apply diagnostics for silent no-op failures by Wenxin-Jiang · Pull Request #53 · SocketDev/socket-patch

Conversation

@Wenxin-Jiang

@Wenxin-Jiang Wenxin Jiang (Wenxin-Jiang) commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Track unmatched manifest entries: After the apply loop, compares targeted manifest PURLs against actually-matched PURLs. Any unmatched entry produces a warning with the specific PURL. Correctly handles PyPI qualified variants and respects --ecosystems filtering.
  • Fail when nothing matches: Changes exit code from 0 to 1 when the manifest has patches in scope but no matching packages are found on disk. Also fails when packages are discovered but none match any targeted manifest entry.
  • Post-apply summary: Prints Summary: X/Y targeted patches applied, Z already patched, W not found on disk so the user always sees the gap.
  • JSON output: Adds unmatchedPatches (count) and unmatchedPurls (list) to --json output.

Addresses findings CRITICAL-1 (zero packages → exit 0), CRITICAL-2 (version mismatch → silent skip), and CRITICAL-3 (no unmatched-manifest diagnostic) from the reliability audit.

Test plan

  • cargo check -p socket-patch-cli compiles
  • cargo test -p socket-patch-cli passes
  • cargo test -p socket-patch-core passes (255 tests)
  • Manual: run apply in a dir with manifest but no node_modules/ — should exit 1 with warning
  • Manual: run apply after npm update changes a version — should warn about unmatched PURL
  • Manual: run apply --ecosystems npm with pypi patches in manifest — pypi patches should NOT appear as unmatched
  • Manual: run apply --json — verify unmatchedPatches and unmatchedPurls fields

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Wenxin-Jiang @claude
fix: add diagnostics to apply command for silent no-op failures in CI
ac4448c
When `apply` runs in CI and no packages match manifest patches, it
previously exited 0 silently, masking configuration errors. This change:

- Tracks which manifest entries actually matched installed packages
- Returns exit code 1 when targeted patches exist but nothing matched
- Emits per-PURL warnings for unmatched manifest entries
- Adds a post-apply summary (applied/already-patched/not-found counts)
- Includes `unmatchedPatches` and `unmatchedPurls` in JSON output
- Changes `apply_patches_inner` signature to return unmatched PURLs

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@Wenxin-Jiang

Wenxin Jiang (Wenxin-Jiang) commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Claude (@claude) review once

claude[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mikolalysenko
Mikola Lysenko (mikolalysenko) approved these changes Apr 7, 2026
View reviewed changes
@Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) merged commit 3764c0b into main Apr 7, 2026
19 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) deleted the fix/apply-diagnostics branch April 7, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikolalysenko Mikola Lysenko (mikolalysenko) mikolalysenko approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Wenxin-Jiang @mikolalysenko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.