GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: add error handling to get command for blob/decode failures by Wenxin-Jiang · Pull Request #54 · SocketDev/socket-patch

Conversation

@Wenxin-Jiang

@Wenxin-Jiang Wenxin Jiang (Wenxin-Jiang) commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Directory creation: Replaced .ok() on create_dir_all for .socket/ and blobs/ with proper error handling that returns exit 1 with descriptive message.
  • Blob write failures: Replaced .ok() on tokio::fs::write with error handling. A write failure now sets a patch_failed flag, breaks out of the file loop, and skips manifest insertion for that patch.
  • Base64 decode failures: Replaced if let Ok(decoded) with match that reports decode errors and skips the patch.
  • Exit code: Changed from always returning 0 to returning 1 when patches_failed > 0 or auto-apply fails.
  • JSON accuracy: "status" now returns "partial_failure" when downloads fail. "applied" field now reflects actual apply outcome instead of always reporting patches_added.
  • One-off mode: Applied the same error handling patterns to save_and_apply_patch.

Addresses findings HIGH-1 (blob write .ok()), HIGH-2 (base64 decode silently skipped), HIGH-4 (directory creation .ok()), HIGH-5 (always exit 0), and HIGH-6 (get --json overstates applied count).

Test plan

  • cargo check -p socket-patch-cli compiles
  • cargo test -p socket-patch-cli passes
  • Manual: run get on a read-only filesystem — should exit 1 with directory creation error
  • Manual: run get --json when apply partially fails — "applied" should be 0, "status" should be "partial_failure"

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Wenxin-Jiang @claude
fix: add error handling to get command for blob writes, decodes, and …
4707c7b
…dir creation

Replace silent .ok() calls on directory creation, blob writes, and
base64 decodes with proper error propagation. Fix the always-exit-0
bug by returning non-zero exit codes on partial failures and apply
failures. Track apply outcome to accurately report "applied" count
in JSON output. Apply the same fixes to both batch and one-off
(save_and_apply_patch) code paths.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@Wenxin-Jiang

Wenxin Jiang (Wenxin-Jiang) commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Claude (@claude) review once

claude[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mikolalysenko
Mikola Lysenko (mikolalysenko) approved these changes Apr 8, 2026
View reviewed changes
@Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) merged commit c1a2bc0 into main Apr 8, 2026
19 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) deleted the fix/get-error-handling branch April 8, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikolalysenko Mikola Lysenko (mikolalysenko) mikolalysenko approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Wenxin-Jiang @mikolalysenko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.