GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: surface crawler find_by_purls errors instead of swallowing by Wenxin-Jiang · Pull Request #55 · SocketDev/socket-patch

Conversation

@Wenxin-Jiang

@Wenxin-Jiang Wenxin Jiang (Wenxin-Jiang) commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaced all 16 instances of if let Ok(packages) = crawler.find_by_purls(...) with match blocks that log warnings to stderr on error.
  • Applies to both find_packages_for_purls (used by apply) and find_packages_for_rollback (used by rollback).
  • Covers all 8 ecosystems: npm, pypi, cargo, gem, golang, maven, composer, nuget.
  • Outer path-discovery errors (e.g., get_node_modules_paths()) were already handled correctly and left unchanged.

Addresses finding HIGH-3 (crawler find_by_purls errors silently swallowed), which feeds into the critical silent-no-op problem when crawler failures reduce the discovered package set to zero.

Test plan

  • cargo check -p socket-patch-cli compiles
  • cargo test -p socket-patch-cli passes
  • Manual: corrupt a package.json in node_modules/, run apply — should see warning about failed scan
  • Manual: same with --silent — warning should be suppressed

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Wenxin-Jiang @claude
fix: surface find_by_purls errors instead of silently swallowing them
6b8234a
Replace all `if let Ok(packages) = crawler.find_by_purls(...)` with
`match` blocks that log warnings on Err when not in silent mode.
Previously, per-path crawler failures (corrupt manifests, permission
denied, etc.) were silently dropped, causing packages to vanish from
discovery without any diagnostic output.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@Wenxin-Jiang

Wenxin Jiang (Wenxin-Jiang) commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Claude (@claude) review once

claude[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mikolalysenko
Mikola Lysenko (mikolalysenko) approved these changes Apr 8, 2026
View reviewed changes
@Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) merged commit 1d59887 into main Apr 8, 2026
19 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) deleted the fix/crawler-error-surfacing branch April 8, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikolalysenko Mikola Lysenko (mikolalysenko) mikolalysenko approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Wenxin-Jiang @mikolalysenko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.