GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci(release): tag after build + fix rustup toolchain setup by mikolalysenko · Pull Request #85 · SocketDev/socket-patch

Conversation

@mikolalysenko

@mikolalysenko Mikola Lysenko (mikolalysenko) commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move the tag job to run after build succeeds, so a failed build no longer leaves a dangling tag behind. All publish jobs (github-release, cargo-publish, npm-publish, pypi-publish) now depend on tag, so we never half-publish without one.
  • Replace dtolnay/rust-toolchain with direct rustup show + rustup target add. The dtolnay action can't auto-detect the channel when pinned by SHA (it normally parses it from the ref name like @stable), which caused the release run to fail with 'toolchain' is a required input. This matches the pattern already used in ci.yml.

Test plan

  • Trigger the Release workflow with dry-run: true and confirm all matrix targets build successfully
  • Confirm no v* tag is created on a dry-run
  • On a real release, confirm the tag is created only after all builds pass, and publish jobs run after the tag

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mikolalysenko @claude
ci(release): tag after build + fix rustup toolchain setup
99c263f
Tag now runs after build succeeds so a failed build no longer leaves
behind a dangling tag. All publish jobs depend on tag, so we never
half-publish without one.

Replaces dtolnay/rust-toolchain (which can't auto-detect the channel
when pinned by SHA) with direct rustup invocation, matching the pattern
already used in ci.yml.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@mikolalysenko
Mikola Lysenko (mikolalysenko) enabled auto-merge (squash) May 27, 2026 14:20
Wenxin-Jiang
Wenxin Jiang (Wenxin-Jiang) approved these changes May 27, 2026
View reviewed changes
@mikolalysenko
Mikola Lysenko (mikolalysenko) merged commit dde67db into main May 27, 2026
32 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mikolalysenko
Mikola Lysenko (mikolalysenko) deleted the fix-release-workflow branch May 27, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wenxin-Jiang Wenxin Jiang (Wenxin-Jiang) Wenxin-Jiang approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mikolalysenko @Wenxin-Jiang
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.