GeezerVison

Summary

Follow-up to #82 (telemetry coverage + paid-tier fallback). PR #82 wired clap::builder::BoolishValueParser onto every bool global with an env attribute so SOCKET_OFFLINE=1, SOCKET_DEBUG=1, etc. parse correctly — previously they crashed clap with error: invalid value '1' for '--offline'.

That commit shipped without paired regression tests; I added them on the same branch but they landed after the squash-merge cutoff. This PR is just those tests, rebased onto the current main.

Two #[serial] tests in crates/socket-patch-cli/tests/cli_global_args.rs:

• bool_env_vars_accept_one_and_yes — SOCKET_OFFLINE=1, SOCKET_GLOBAL=yes, SOCKET_JSON=on, SOCKET_VERBOSE=1, SOCKET_SILENT=y, SOCKET_DRY_RUN=1, SOCKET_YES=yes, SOCKET_BREAK_LOCK=1, SOCKET_DEBUG=1, SOCKET_TELEMETRY_DISABLED=1 all parse as true.
• bool_env_vars_reject_zero_and_falsey — SOCKET_OFFLINE=0, SOCKET_DEBUG=false, SOCKET_TELEMETRY_DISABLED=no, SOCKET_JSON=off all parse as false. Guards against an over-eager parser flipping a bool on any non-empty string.

The existing env_vars_populate_global_args is also marked #[serial] in this commit — env-var state is process-global, so without serialization the negative-case test flakes by inheriting SOCKET_OFFLINE=1 from the positive case running concurrently.

Test plan

• cargo test -p socket-patch-cli --test cli_global_args clean against current main (post-refactor in refactor: dedupe ecosystem dispatch, telemetry, API client, cleanup, get #88).
• Both new tests pass; existing 4 tests in the file still pass.
• No production code changes — pure test coverage.

Assisted-by: Claude Code:opus-4-7