GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable pip's cache during the Docker image build by mtorp · Pull Request #446 · SocketDev/socket-python-cli

Conversation

@mtorp

@mtorp Martin Torp (mtorp) commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The v2.11.14 release (run 43215227149) published to PyPI but failed in the Docker build step, so socketdev/cli:2.11.14 wasn't pushed until a re-run.

Root Cause

Inside the Docker build, pip install socketsecurity==2.11.14 failed all 10 retries over about 5 minutes. The version list pip saw stopped at 2.11.13, so it was reading a stale PyPI Simple index. The host-side "Verify package is installable" step had already installed 2.11.14 a minute earlier.

pip caches index responses for up to 10 minutes. Once the first attempt in the Docker build got the stale copy, every retry reused it. The verify step in release.yml avoids this with --no-cache-dir, but the Dockerfile retry loop didn't.

Fix

Add ARG PIP_NO_CACHE_DIR=1 at the top of the image build. That turns pip's cache off for every pip call while building, including the CLI install retries, so each attempt fetches a fresh index. It's an ARG, so it doesn't carry into the published image. #439 adds the same ARG. Bumps to 2.11.15 for the version check.

Public Changelog

N/A

Expected reviewer effort: Stamp

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mtorp
Disable pip's cache in the Docker image's CLI install retries
47716c8 
The v2.11.14 release published to PyPI but failed to push the Docker
image. The first pip install inside the build saw a stale PyPI index
without 2.11.14, and pip cached that response, so all ten retries
reused it and never saw the release.

Pass --no-cache-dir to the CLI and SDK installs so each retry fetches
the index fresh. The release workflow's host-side verify step already
does this. Bump to 2.11.15.
@mtorp
Martin Torp (mtorp) requested a review from a team as a code owner November 12, 2026 12:22
@cursor

cursor Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Summary

Low Risk
Docker build-only change to pip flags plus a patch release bump; no runtime CLI behavior change.

Overview
Fixes Docker image publishing when PyPI is slow to list a new socketsecurity release. During image build, the retry loop’s pip install socketsecurity==$CLI_VERSION could keep reusing a cached Simple API index (up to ~10 minutes), so all 10 retries still saw the previous version even though the package was already on PyPI—leaving PyPI updated but socketdev/cli tags missing.

The Dockerfile now passes --no-cache-dir on those pip install calls (CLI retry loop and optional socketdev install), matching the release workflow’s verify step, and documents why. Version is bumped to 2.11.15 with a changelog note.

Reviewed by Cursor Bugbot for commit 47716c8. Configure here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mtorp
Martin Torp (mtorp) deployed to socket-firewall November 12, 2026 12:22 — with GitHub Actions Active
@mtorp
Martin Torp (mtorp) requested a review from Oskar Haarklou Veileborg (BarrensZeppelin) November 12, 2026 12:24
BarrensZeppelin
Oskar Haarklou Veileborg (BarrensZeppelin) approved these changes Nov 12, 2026
View reviewed changes

@BarrensZeppelin Oskar Haarklou Veileborg (BarrensZeppelin) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Dockerfile Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mtorp
Disable pip's cache through a build-time ARG
5780789 
Set PIP_NO_CACHE_DIR=1 as an ARG at the top of the image build, the same
way #439 does, so every pip call during the build skips the cache. This
covers the CLI install retries and replaces the per-call flags.
@mtorp
Martin Torp (mtorp) deployed to socket-firewall November 12, 2026 13:43 — with GitHub Actions Active
@mtorp Martin Torp (mtorp) changed the title Disable pip's cache in the Docker image's CLI install retries Disable pip's cache during the Docker image build Nov 12, 2026
@mtorp
Martin Torp (mtorp) merged commit e35fc59 into main Nov 12, 2026
33 checks passed

Uh oh!

There was an error while loading. Please reload this page.

This branch was successfully deployed

1 active deployment
socket-firewall — 5780789b Deployed Nov 12, 2026 by mtorp via python-sfw-smoke-enterprise #575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BarrensZeppelin Oskar Haarklou Veileborg (BarrensZeppelin) BarrensZeppelin approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mtorp @BarrensZeppelin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.