GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — Bugfix/action/get contents with decode parameter by userlocalhost · Pull Request #42 · StackStorm-Exchange/stackstorm-github Conversation
Contributor
Close: #41 This commit changed decoding processing of getting content to use ContentFile.decoded_content method instead of self-implemented one.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThis commit changed decoding processing of getting content to use ContentFile.decoded_content method instead of self-implemented one. Because the PyGithub, which this pack depends on, have already implemented decoding processing for content of ContentFile.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. In the previous implementation uses custom decoding method of `lib.formatters.base64_decode` when `github.create_file` and `github.update_file` actions are called with "encoding" parameter. And those will be failed because of its implementation. This removes `lib.formatters.base64_decode` method because it is not used any more except for above actions, which is wrong the way of using.
userlocalhost
force-pushed
the
bugfix/action/get_contents_with_decode_paramter
branch
from
230c323 to
b335d47
Compare
It's necessary for decode processing for the value that is get from `github.ContentFile.ContentFile.decoded_content` because it returns bytes typed value. This commit added its processing at `lib.formatters.contents_to_dict` method. (c.f. https://pygithub.readthedocs.io/en/latest/github_objects/ContentFile.html)
userlocalhost
force-pushed
the
bugfix/action/get_contents_with_decode_paramter
branch
from
caa1432 to
a43361e
Compare
arm4b
approved these changes
|
There was an error while loading. Please reload this page.
|
@userlocalhost is the change here still actual, can I merge it? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@userlocalhost @armab Faced the same issue. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
The "github.get_contents" action will fail when decode parameter is set
There was an error while loading. Please reload this page.