GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Modification in the descriptions and actions along with tests. by ankitaOrch · Pull Request #30 · StackStorm-Exchange/stackstorm-sql

Conversation

@ankitaOrch

@ankitaOrch ankitaOrch commented Jan 8, 2024

Copy link
Copy Markdown

Updated the descriptions of all parameters in the pack that take a JSON input to use double-quotes. The descriptions currently give examples with single-quotes, which do not work in the ST2 UI.
Also, Insert, Update, and Delete actions in the SQL pack only search the 'dbo' schema. Added schema parameter to support different schemas in the actions and modified to accommodate triggers.
Also modified the tests to accommodate the schema change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ankita-orchestral
Modification in the descriptions and actions along with tests
b135849
@CLAassistant

CLAassistant commented Jan 8, 2024

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ankita-orchestral added 7 commits January 8, 2024 09:36
@ankita-orchestral
Updated changes log and pack details
c28644f
@ankita-orchestral
Updated insert script
b6860d2
@ankita-orchestral
Updated insert script
0dd1536
@ankita-orchestral
Updated insert script for inline comment
1385e16
@ankita-orchestral
Updated insert script pylint errors
70abdee
@ankita-orchestral
Updated insert script pylint errors
e5c200d
@ankita-orchestral
Updated insert script pylint unexpected-keyword-arg error
b8ceadb
@nzlosh nzlosh mentioned this pull request Feb 13, 2024
TSC Meeting (13 Feb 2024) StackStorm/community#131
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ankitaOrch @CLAassistant @ankita-orchestral
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.