GeezerVison

packages/create/src/package-json.ts (1)

136-169: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicate router-plugin/router-core handling between react and solid branches.

The routerPluginVersion computation, moving @tanstack/router-plugin to devDependencies, and adding @tanstack/router-core to dependencies is copy-pasted verbatim across the react and solid branches. Extracting a shared helper would reduce duplication and the risk of the two branches drifting apart on future edits.

♻️ Suggested refactor

+  function applyRouterOnlyCompat() {
+    const routerPluginVersion =
+      packageJSON.devDependencies?.['`@tanstack/router-plugin`'] ??
+      packageJSON.dependencies?.['`@tanstack/router-plugin`'] ??
+      'latest'
+    delete packageJSON.dependencies?.['`@tanstack/router-plugin`']
+    packageJSON.devDependencies = {
+      ...(packageJSON.devDependencies ?? {}),
+      '`@tanstack/router-plugin`': routerPluginVersion,
+    }
+    packageJSON.dependencies = {
+      ...(packageJSON.dependencies ?? {}),
+      '`@tanstack/router-core`':
+        packageJSON.dependencies?.['`@tanstack/router-core`'] ?? 'latest',
+    }
+  }
+
   if (options.routerOnly) {
     if (options.framework.id === 'react') {
       delete packageJSON.dependencies?.['`@tanstack/react-start`']
       delete packageJSON.dependencies?.['`@tanstack/react-router-ssr-query`']
-      const routerPluginVersion = ...
-      ...
+      applyRouterOnlyCompat()
     }

     if (options.framework.id === 'solid') {
       delete packageJSON.dependencies?.['`@tanstack/solid-start`']
       delete packageJSON.dependencies?.['`@tanstack/solid-router-ssr-query`']
-      const routerPluginVersion = ...
-      ...
       delete packageJSON.scripts?.start
+      applyRouterOnlyCompat()
     }
   }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/create/src/package-json.ts` around lines 136 - 169, The react and
solid branches in packageJSON handling duplicate the same router plugin/core
migration logic, so extract that shared work into a helper and call it from both
branches. Move the routerPluginVersion lookup, deletion of
`@tanstack/router-plugin` from dependencies, promotion into devDependencies, and
ensuring `@tanstack/router-core` stays in dependencies into a reusable function
referenced by the package-json.ts flow, keeping the framework-specific deletions
separate.