GeezerVison

Every fresh scaffold that includes tanstack-query ships TypeScript errors out of the box. Generated projects set noUnusedLocals: true, and three imports in the templates are never used, all residue of earlier migrations that moved the code but left the import lines behind.

To be precise about severity: this is not a broken build. vite build doesn't typecheck (esbuild strips types), so the apps build and run fine. It's red squiggles in every new project from the second it opens in an editor, and a hard failure the moment anyone runs tsc.

Reproduce

npx @tanstack/cli create demo --add-ons tanstack-query -y
cd demo && npx tsc --noEmit

src/router.tsx(4,1): error TS6133: 'ReactNode' is declared but its value is never read.
src/router.tsx(5,1): error TS6133: 'QueryClient' is declared but its value is never read.
src/router.tsx(7,8): error TS6133: 'TanstackQueryProvider' is declared but its value is never read.

Add tRPC and you also get:

src/integrations/tanstack-query/root-provider.tsx(2,23): error TS6133: 'QueryClientProvider' is declared but its value is never read.
src/routes/api.trpc.$.tsx(1,1): error TS6133: 'createServerFileRoute' is declared but its value is never read.
src/routes/api.trpc.$.tsx(1,10): error TS2305: Module '"@tanstack/react-start/server"' has no exported member 'createServerFileRoute'.

What's wrong

1. project/base/src/router.tsx.ejs (commit 1) — the tanstack-query branch imports four things, but QueryClient is never referenced in any branch, and ReactNode / the TanstackQueryProvider default export are referenced only inside the addOnEnabled.tRPC Wrap block. Only getContext and setupRouterSsrQueryIntegration are used unconditionally. Fix: gate the two tRPC-only imports behind addOnEnabled.tRPC, delete QueryClient.

2. add-ons/tRPC/assets/src/routes/api.trpc.$.tsx (commit 2) — imports createServerFileRoute, but the route body already uses the current API (createFileRoute with server: { handlers: ... }). The migration landed, the import didn't get removed. That symbol is no longer exported at all, so it's both unused and unresolvable.

3. add-ons/tanstack-query/.../root-provider.tsx.ejs (commit 2) — the tRPC branch imports QueryClientProvider but renders TRPCProvider; setupRouterSsrQueryIntegration is what supplies the query client.

setupRouterSsrQueryIntegration is deliberately left alone — it's used further down the router template, and removing it silently breaks SSR query dehydration. Solid's router.tsx.ejs is already correct.

Split into two commits, one per concern, with a changeset each.

Verification

Scaffolded with the built CLI, fully installed, typechecked and built:

vite build on the tRPC scaffold: exit 0. Unit suites green — 101 @tanstack/cli, 248 @tanstack/create.

Prior art

Issue #272 ("Provider ... is not used"), closed by #356. The router imports are leftover residue of that fix — the Wrap block got gated, the imports did not. Not a duplicate, the still-live remainder.

Summary by CodeRabbit

• Bug Fixes
  • Fixed generated React projects with TanStack Query and tRPC so they no longer include unused or invalid imports.
  • Corrected the generated tRPC API route to properly handle both GET and POST requests.
  • Resolved scaffold validation errors when unused-local checks are enabled.
• Chores
  • Added release notes documenting the generated project fixes.