GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(create): preserve ignored existing add-on targets by tannerlinsley · Pull Request #554 · TanStack/cli

Conversation

tannerlinsley commented Nov 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Adding pnpm build settings could silently replace an existing .npmrc when it was ignored by git. Load existing output targets before merging so registry settings survive and overwrite confirmation also covers ignored or empty files.

AI review notes:
Five real filesystem regressions fail on current main and pass with this change. They cover preserving synthetic registry settings, cancellation without writes, an explicit root-check setting, an empty existing file and another ignored output target.
The frozen install and affected lint pass. The unchanged normal hook built all 10 projects and passed 550 unit tests. All eight blocking Chrome e2e tests passed and the normal hook exited successfully.
An actual compiled CLI blank scaffold outside the monorepo followed by the compiled addToApp flow retained synthetic registry settings and added the standalone pnpm setting. The install command was recorded rather than executed in that fixture. The normal browser gates separately cover installed generated apps and production-valid blank and AI builds without provider calls.
No dependencies, public API or workflow changes. The compiled add-to-app module adds 683 raw bytes and 162 gzip bytes, measured against the accepted current-main build. This is a leaf-module measurement, not a whole-package or startup claim.
Includes an @tanstack/create patch changeset. Publishing remains dependent on resolving the staged core artifact tracked in #551.

Summary by CodeRabbit

Bug Fixes
- Existing ignored files are now considered when adding pnpm workspace settings, helping preserve .npmrc registry configuration.
- You’re prompted before an ignored file is overwritten, and can cancel the operation to keep its contents.
- Empty ignored files are also recognized as existing, helping prevent unintended overwrites.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix(create): preserve ignored existing add-on targets

d6bb4da

changeset-bot Bot commented Nov 3, 2026

Copy link

Copy Markdown

🦋 Changeset detected

Latest commit: d6bb4da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@tanstack/create	Patch
create-start-app	Patch
create-tanstack-app	Patch
create-tanstack	Patch
create-tsrouter-app	Patch
@tanstack/create-start	Patch
@tanstack/cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

writeFiles now includes existing ignored output targets in merge and overwrite checks. It also treats empty existing files as present. Tests cover .npmrc preservation and overwrite cancellation.

Changes: Ignored file handling

Layer / File(s)	Summary
Load existing output targets `packages/create/src/add-to-app.ts`, `.changeset/preserve-ignored-npmrc.md`	`writeFiles` loads existing generated targets, including `.npmrc` when generating `pnpm-workspace.yaml`. It checks file presence even when the contents are empty. The Changeset declares a patch release.
Test ignored target behavior `packages/create/tests/ignored-npmrc.test.ts`	Tests cover `.npmrc` merging and preservation, prompt behavior, cancellation, empty ignored files, and protection of another ignored target.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

TanStack/cli#485: Defines the standalonePnpmNpmrc behavior that this change uses when merging existing .npmrc contents.

Merge Risk: Minimal · up to d6bb4

Ignored target files are included in merge and overwrite checks. No material merge-blocking issue was identified.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preserving ignored existing add-on targets in the create flow.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

Generate docstrings

Commit to this branch
Create a new PR

Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/create/tests/ignored-npmrc.test.ts

Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser.
The file was not found in any of the provided project(s): packages/create/tests/ignored-npmrc.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

Source mode: Auto

Repository: Unavailable

Branch: Unavailable

File: No configuration file from this repository applied

Commit: Unavailable

Layers: defaults

Review profile: CHILL

Plan: Advanced

Run ID: `92f02b71-3c7b-4a14-ae85-1885b255e5b6`

Commits

Reviewing files that changed from the base of the PR and between `9e61578` and `d6bb4da`.

Files selected for processing: 3

`.changeset/preserve-ignored-npmrc.md`

`packages/create/src/add-to-app.ts`

`packages/create/tests/ignored-npmrc.test.ts`

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tannerlinsley merged commit fac419e into main

Nov 3, 2026

7 checks passed

Uh oh!

There was an error while loading. Please reload this page.

tannerlinsley deleted the taren/factory-preserve-ignored-npmrc branch

November 3, 2026 19:38

github-actions Bot mentioned this pull request

Nov 3, 2026

ci: Version Packages #552

Merged

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tannerlinsley commented Nov 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Nov 3, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeRabbit Verify

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tannerlinsley commented Nov 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.