GeezerVison is showing github.com — Convert the repository into a Java project · Issue #474 · TheAlgorithms/Java
Convert the repository into a Java project #474Description@christianbender @AnupKumarPanwar @dynamitechetan
This is something which something which we have discussed in the past and have been raised by multiple users of the repo. The repo can be converted to a complete Java project with correct package structure, JUnit tests and Java language standard checkers. I want that anyone who is adding a new algorithm should add respective tests and follow a set coding standard so that the repo can become more usable for users who can then clone it into a local IDE and work on it.
Similar to Scala Repo
I propose that we create a development branch on which we can start making the changes and replace it with the master once it fulfills the above-mentioned requirement. I would like to take the initiative and start this task.
Please share your feedback. Reacted by Mahmoud Khalil, Leif Gruenwoldt, kaypeegithub, CoderP, Zachary, xletme, GQH1993, Danpatpang, Vishal Gole, Alex and 13 more Reacted by CoderP and zhousFOREVER Activityburnz248 commented on Jul 29, 2018 Hey Anup. I would like to help with this as well. Let me know what you need help with MarisaAfuera commented on Jul 30, 2018 Hi Anup. Great idea. I also can help if you need. rahul-vishwadhaar commented on Aug 3, 2018 Hello Anup,
This seems to be great thing. Please let me know if I can contribute. ahmedsameha1 commented on Aug 4, 2018 mkabdullahi commented on Aug 5, 2018 Also, I am in and happy to contributes lq920320 commented on Aug 10, 2018 So great, happy to join and contribute. esarella commented on Aug 15, 2018 Presently working on solving most problems. I'm more than willing to help and contribute. asdiamond commented on Aug 15, 2018 I can definitely help and contribute to this. giannisal commented on Aug 20, 2018 I'd love to contribute to make this repo a java project.
From what I've seen so far, the development branch is identical to the master in terms of structure and content. I'm used to working with maven in Java, however I saw that the scala repo is based on Travis CI. Would you like me to work on either of them, create the project and test for some of the existing classes? varunu28 commented on Aug 23, 2018 ContributorAuthor More actions @giannisal I initially created the development branch. I would move the code to that branch in a project structure by the weekend and would update the README for the test case format. After that we can start accepting contributions to the development branch for the tests
We are using ScalaTest spec in the Java repo varunu28 commented on Aug 24, 2018 ContributorAuthor More actions I have updated the development branch and added a instructions to the README. We can start with the migration.
@christianbender Please make sure every PR is adhering to the points mentioned in README on Development branch lq920320 commented on Aug 25, 2018 which build tool should be used, maven or gradle? @varunu28 I didn't see on the Development branch. asdiamond commented on Aug 25, 2018 varunu28 commented on Aug 25, 2018 ContributorAuthor More actions @lq920320 As of now we are concentrating on adding test coverage. We would be deciding on the build tool later mainrs commented on Aug 25, 2019 I've added a PR #815 that cleans up the code base to make working on it easier. After it gets merged I'll start with adding tests and all missing algorithms to the repo. jayyusi commented on Sep 14, 2019 is this still going on ? If yes, I want in on it !! Which algorithms need JUnit tests ? mainrs commented on Sep 14, 2019 Just take a look at the development branch. Everything in there is OK. Everything else needs a port plus Junit tests jayyusi commented on Sep 14, 2019
Just take a look at the development branch. Everything in there is OK. Everything else needs a port plus Junit tests
Here's a question before I dive into this.
CombSort.java exists in the master branch, but doesn't exist in the development branch. So based on what you said, it needs a test, can you confirm ? and what do you mean by port ?
Thanks mainrs commented on Sep 14, 2019 If it doesn't exist in development you have to get the code from master and add it to development. After that, you need to write unit tests for it. The tests should cover up most of the behavior of each algorithm. Like exceptions that might be thrown, wrong input formats etc.
By port I meant taking the algorithm from master and adding it to development. They need some tweaking because you don't need the main method anymore. The stuff in main should be covered by the tests.
You also need to add package statements because the project structure changed to maven. jayyusi commented on Sep 14, 2019
If it doesn't exist in development you have to get the code from master and add it to development. After that, you need to write unit tests for it. The tests should cover up most of the behavior of each algorithm. Like exceptions that might be thrown, wrong input formats etc.
By port I meant taking the algorithm from master and adding it to development. They need some tweaking because you don't need the main method anymore. The stuff in main should be covered by the tests.
You also need to add package statements because the project structure changed to maven.
Great, thank you, I will get to it soon, I'm gonna do CombSort.java first. jayyusi commented on Sep 14, 2019 I've added PR #825, which has 2 new files:
- CombSort.java ( copied from master as is, with minor changes to import statements and class interface implementation to accommodate project structure changes )
- CombSortTest.java ( which has 4 tests within it, Integer, String, Double, Character )
mainrs commented on Sep 15, 2019 Looks good.
Edit: Added some changes that you should make to match with java's coding style. renjithgr commented on Sep 28, 2019 Hi all,
I raised a pull request to change the build tool from Maven to Gradle. #902
Nowadays, Gradle is the most common build tool for new Java projects. burnz248 commented on Apr 29, 2020 Is this still something that needs to be addressed? Adhikaribharath commented on May 13, 2020 Is this still on going task? If so I would like to contribute :) Detective-Khalifah commented on May 28, 2020 stale commented on Mar 20, 2021 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|