GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Implementation of Edit Distance in Java by sanghaisubham · Pull Request #226 · TheAlgorithms/Java

Conversation

@sanghaisubham

@sanghaisubham sanghaisubham commented Oct 19, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

@varunu28

I have implemented the Edit Distance in Java. Please Review and comment and I will make the necessary changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sanghaisubham sanghaisubham changed the title @varunu28 I have implemented the Edit Distance in Java. Please Review and comment and I will make the necessary changes. Implementation of Edit Distance in Java Oct 19, 2017
varunu28
varunu28 suggested changes Oct 19, 2017
View reviewed changes

@varunu28 varunu28 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the unused libraries for map and hashmap

  • Create a description for the minDistance function in a similar manner as it is in other codes for repo.Ex InsertionSort

  • Add space between class declaration and function to improve readability

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dynamitechetan sanghaisubham
Merge pull request TheAlgorithms#137 from daniel-mueller/coding-style…
b7b9443 
…-fixes

turned some public methods private
@sanghaisubham
sanghaisubham force-pushed the editdistance branch from e4a7a3d to 700df64 Compare October 20, 2017 09:18
@sanghaisubham

sanghaisubham commented Oct 20, 2017

Copy link
Copy Markdown
Author

@varunu28

I have made the required changes.Please have a look and let me know if any other thing needs to be updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sanghaisubham added 2 commits October 20, 2017 20:06
sanghaisubham
Updted Edit Distance In Java by adding description
35771f2
sanghaisubham
Merge branch 'master' of https://github.com/TheAlgorithms/Java into e…
700df64 
…ditdistance
@christianbender
christianbender merged commit 0aae345 into TheAlgorithms:master Mar 31, 2018
@roshankumar447 roshankumar447 mentioned this pull request Nov 7, 2026
feat: add InvertBinaryTree algorithm with tests #7735
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@varunu28 varunu28 varunu28 requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sanghaisubham @varunu28 @christianbender @dynamitechetan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.