GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Increase recursive GCD by teerapat1739 · Pull Request #283 · TheAlgorithms/Java

Conversation

@teerapat1739

@teerapat1739 teerapat1739 commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@teerapat1739
Increase recursive GCD
3bd769d
varunu28
varunu28 suggested changes Oct 27, 2017
View reviewed changes

@varunu28 varunu28 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change the function name and move the function inside the class
  • Update the comments explaining the function and parameters to be passed
  • Add a main method and add a test case showing the expected results

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@teerapat1739
create main function GCD
cc6af5f 
output 4
main
teerapat1739
teerapat1739 commented Oct 27, 2017
View reviewed changes

@teerapat1739 teerapat1739 left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase function main to test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@teerapat1739
Update GCD.java
205698d
@varunu28
varunu28 merged commit c8038cd into TheAlgorithms:master Nov 2, 2017
@roshankumar447 roshankumar447 mentioned this pull request Nov 7, 2026
feat: add MoveZeroes algorithm with tests #7738
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@varunu28 varunu28 varunu28 requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@teerapat1739 @varunu28
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.