GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — used to find the shorthest paths among all pairs of nodes in a graph, by ayushnagar123 · Pull Request #389 · TheAlgorithms/Java

Conversation

@ayushnagar123

@ayushnagar123 ayushnagar123 commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

Floyd-Warshall algorithm is a procedure, which is used to find the shorthest (longest) paths among all pairs of nodes in a graph, which does not contain any cycles of negative lenght. The main advantage of Floyd-Warshall algorithm is its simplicity.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ayushnagar123
used to find the shorthest paths among all pairs of nodes in a graph,
35a4bd3 
Floyd-Warshall algorithm is a procedure, which is used to find the shorthest (longest) paths among all pairs of nodes in a graph, which does not contain any cycles of negative lenght. The main advantage of Floyd-Warshall algorithm is its simplicity.
christianbender
christianbender requested changes Mar 29, 2018
View reviewed changes

@christianbender christianbender left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work! I have some requests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Data Structures/Graphs/FloydWarshall.java


public class FloydWarshall

@christianbender christianbender Mar 29, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary empty lines.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Data Structures/Graphs/FloydWarshall.java

{

adjacency_matrix[source][destination] = scan.nextInt();

@christianbender christianbender Mar 29, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spare the user for unnecessary inputs if the inputs will be overwrite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Data Structures/Graphs/FloydWarshall.java

{

private int distancematrix[][];

@christianbender christianbender Mar 29, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming conventions: Use camel case
For example distanceMatrix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Data Structures/Graphs/FloydWarshall.java

{

adjacency_matrix[source][destination] = 0;

@christianbender christianbender Mar 29, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camel case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Data Structures/Graphs/FloydWarshall.java

{

distancematrix = new int[numberofvertices + 1][numberofvertices + 1];

@christianbender christianbender Mar 29, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please initialize the array 'distancematrix' with zeros. for safety.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@christianbender christianbender added the on hold label Mar 29, 2018
christianbender
christianbender requested changes Mar 29, 2018
View reviewed changes
Comment thread Data Structures/Graphs/FloydWarshall.java

}


@christianbender christianbender Mar 29, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in comments in your code. Makes the program readable for others.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@christianbender christianbender closed this Apr 8, 2018
@christianbender christianbender added the out of date label Apr 8, 2018
@roshankumar447 roshankumar447 mentioned this pull request Nov 7, 2026
feat: add FindTheDifference algorithm with tests #7741
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianbender christianbender christianbender requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ayushnagar123 @christianbender
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.