GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: avoid out-of-bounds access in HowManyTimesRotated on small/unrotated arrays by Saadanjum0 · Pull Request #7626 · TheAlgorithms/Java

Conversation

@Saadanjum0

@Saadanjum0 Saadanjum0 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

The previous implementation compared a[mid-1]/a[mid+1], which indexes out of bounds for a 1-2 element array and loops forever on an already-sorted (unrotated) array. Replaced with a standard binary search for the rotation pivot (compare a[mid] against a[high]). Added regression tests for unrotated, single-element, and two-element arrays.

This same root cause was reported and attempted before in #3544 (2022), which went stale and was closed without merging.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new algorithms include a corresponding test class that validates their functionality.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Saadanjum0
fix: avoid out-of-bounds access in HowManyTimesRotated on small/unrot…
ba654ca 
…ated arrays

The old mid-1/mid+1 comparison indexed out of bounds for a 1-2 element
array and never terminated correctly for an unrotated array. Replaced
with a standard binary search for the rotation pivot.
@Saadanjum0
Saadanjum0 requested review from DenizAltunkapan, alxkm and yanglbme as code owners October 2, 2026 12:49
@codecov-commenter

codecov-commenter commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.64%. Comparing base (b33b75b) to head (ba654ca).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7626      +/-   ##
============================================
+ Coverage     81.62%   81.64%   +0.01%     
- Complexity     8162     8163       +1     
============================================
  Files           837      837              
  Lines         25656    25653       -3     
  Branches       5011     5009       -2     
============================================
+ Hits          20942    20944       +2     
+ Misses         3924     3922       -2     
+ Partials        790      787       -3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
alxkm
alxkm approved these changes Oct 2, 2026
View reviewed changes

@alxkm alxkm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the contribution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alxkm
alxkm merged commit ed2928f into TheAlgorithms:master Oct 2, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxkm alxkm alxkm approved these changes
@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner
@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Saadanjum0 @codecov-commenter @alxkm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.