GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Improve pyramid surface area validation and readability by FarhanQ19 · Pull Request #7670 · TheAlgorithms/Java

Conversation

FarhanQ19 commented Oct 28, 2026

Copy link

Copy Markdown

Updated surfaceAreaPyramid to provide a descriptive error message for invalid side lengths and declared the calculation variables final.

Verified that Area.java compiles successfully using javac with exit code 0. No automated tests were run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Improve pyramid area validation message and variable declarations

5f1073d

FarhanQ19 requested review from DenizAltunkapan, alxkm and yanglbme as code owners

October 28, 2026 18:05

codecov-commenter commented Oct 28, 2026

Copy link

Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (a7a2441) to head (5f1073d).

Files with missing lines	Patch %	Lines
src/main/java/com/thealgorithms/maths/Area.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #7670   +/-   ##
=========================================
  Coverage     82.21%   82.22%           
- Complexity     8401     8403    +2     
=========================================
  Files           843      843           
  Lines         26141    26141           
  Branches       5100     5100           
=========================================
+ Hits          21493    21495    +2     
  Misses         3854     3854           
+ Partials        794      792    -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

FarhanQ19 commented

Oct 28, 2026

View reviewed changes

FarhanQ19 left a comment

Copy link

Copy Markdown

Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review completed for this individual lab. I checked input validation, the surface-area calculation, and variable declarations. Area.java compiled successfully with exit code 0; automated tests were not run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/main/java/com/thealgorithms/maths/Area.java

		if (slantHeight <= 0) {
		throw new IllegalArgumentException("slant height must be greater than 0");
		throw new IllegalArgumentException(
		"slant height must be greater than 0");

FarhanQ19 Oct 28, 2026

Copy link

Copy Markdown

Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: The slant-height check rejects zero and negative values. Automated tests should verify that both cases throw IllegalArgumentException.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

src/main/java/com/thealgorithms/maths/Area.java

		double baseArea = sideLength * sideLength;
		double lateralSurfaceArea = 2 * sideLength * slantHeight;

		final double baseArea = sideLength * sideLength;

FarhanQ19 Oct 28, 2026

Copy link

Copy Markdown

Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: Declaring the calculation variables final makes it clear that they are not reassigned. The surface-area formula remains unchanged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

DenizAltunkapan commented Nov 1, 2026

Copy link

Copy Markdown

Member

Thanks for your contribution. The validation message improvements overlap with PR #7686, which addresses the same issue and additionally includes unit tests. While the formatting changes are reasonable, maintaining two PRs for the same small improvement is unnecessary. I'm closing this one in favor of the more comprehensive, tested solution in #7686.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DenizAltunkapan closed this

Nov 1, 2026

Reviewers

DenizAltunkapan

Awaiting requested review from DenizAltunkapan

DenizAltunkapan is a code owner

yanglbme

Awaiting requested review from yanglbme

yanglbme is a code owner

alxkm

Awaiting requested review from alxkm

alxkm is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.