GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added surface area calculation for pyramid by tah-6 · Pull Request #7691 · TheAlgorithms/Java

Conversation

@tah-6

@tah-6 tah-6 commented Oct 29, 2026

Copy link
Copy Markdown
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new algorithms include a corresponding test class that validates their functionality.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Syed Irfan
Added surface area calculation for pyramid
5db6ece
@tah-6
tah-6 requested review from DenizAltunkapan, alxkm and yanglbme as code owners October 29, 2026 19:48
tah-6
tah-6 commented Oct 29, 2026
View reviewed changes
Comment thread src/main/java/com/thealgorithms/maths/Area.java
}
if (slantHeight <= 0) {
throw new IllegalArgumentException("slant height must be greater than 0");
throw new IllegalArgumentException("Must be a positive slantHeight");

@tah-6 tah-6 Oct 29, 2026

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codecov-commenter

codecov-commenter commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (2319794) to head (5db6ece).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/maths/Area.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #7691   +/-   ##
=========================================
  Coverage     82.22%   82.22%           
  Complexity     8403     8403           
=========================================
  Files           843      843           
  Lines         26141    26141           
  Branches       5100     5100           
=========================================
  Hits          21495    21495           
  Misses         3854     3854           
  Partials        792      792

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DenizAltunkapan

DenizAltunkapan commented Nov 1, 2026

Copy link
Copy Markdown
Member

Thanks for your contribution. This PR only updates the validation error messages of the existing surfaceAreaPyramid() method. PR #7686 already addresses the same issue and additionally includes tests covering valid and invalid inputs. To avoid maintaining multiple overlapping PRs for the same change, I'm closing this one in favor of #7686.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DenizAltunkapan DenizAltunkapan closed this Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner
@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner
@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tah-6 @codecov-commenter @DenizAltunkapan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.