GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Added surface area calculation for pyramid by mkuttempp · Pull Request #7701 · TheAlgorithms/Java

Conversation

mkuttempp commented Oct 30, 2026

Copy link

Copy Markdown

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
All new algorithms include a corresponding test class that validates their functionality.
All new code is formatted with clang-format -i --style=file path/to/your/file.java

Description: Added a new method called surfaceAreaPyramid to the Area class.
The method calculates the surface area of a pyramid with a square base using the side length and slant height.
Added input validation to ensure both values are positive before performing the calculation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Added surface area calculation for pyramid

cbd67c9

mkuttempp requested review from DenizAltunkapan, alxkm and yanglbme as code owners

October 30, 2026 00:05

codecov-commenter commented Oct 30, 2026

Copy link

Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.23%. Comparing base (410f087) to head (cbd67c9).

Files with missing lines	Patch %	Lines
src/main/java/com/thealgorithms/maths/Area.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #7701      +/-   ##
============================================
+ Coverage     82.22%   82.23%   +0.01%     
- Complexity     8402     8405       +3     
============================================
  Files           843      843              
  Lines         26143    26143              
  Branches       5101     5101              
============================================
+ Hits          21495    21498       +3     
  Misses         3854     3854              
+ Partials        794      791       -3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mkuttempp commented

Oct 30, 2026

View reviewed changes

Comment thread

src/main/java/com/thealgorithms/maths/Area.java

		*
		* @param sideLength side length of the square base
		* @param slantHeight slant height of the pyramid
		* @return surface area of the given pyramid

mkuttempp Oct 30, 2026

Copy link

Copy Markdown

Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code comment line

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

DenizAltunkapan commented Nov 1, 2026

Copy link

Copy Markdown

Member

Thanks for contributing. The surfaceAreaPyramid() method is already implemented in Area.java. This PR comments out the existing implementation and introduces essentially the same method again, with only minor changes to validation messages. Keeping the old implementation as commented-out code is unnecessary and reduces maintainability. PR #7686 addresses the validation messages more cleanly and includes tests, so I'm closing this redundant change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DenizAltunkapan closed this

Nov 1, 2026

Reviewers

DenizAltunkapan

Awaiting requested review from DenizAltunkapan

DenizAltunkapan is a code owner

yanglbme

Awaiting requested review from yanglbme

yanglbme is a code owner

alxkm

Awaiting requested review from alxkm

alxkm is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.