GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix empty error message for pyramid side length by Axsasf · Pull Request #7723 · TheAlgorithms/Java

Conversation

@Axsasf

@Axsasf Axsasf commented Nov 2, 2026

Copy link
Copy Markdown

Description

Fixed an empty IllegalArgumentException message in the surfaceAreaPyramid method of Area.java.

Changes Made

  • Replaced the empty exception message with "Must be a positive sideLength".
  • Improved the error message when the side length is zero or negative.
  • Left the remaining functionality unchanged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Axsasf
Fixed pyramid side length error message
ce6a697
@codecov-commenter

codecov-commenter commented Nov 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (8b49bc5) to head (8e2bbc0).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/maths/Area.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7723      +/-   ##
============================================
- Coverage     82.23%   82.22%   -0.01%     
  Complexity     8402     8402              
============================================
  Files           843      843              
  Lines         26140    26140              
  Branches       5100     5100              
============================================
- Hits          21495    21493       -2     
- Misses         3853     3854       +1     
- Partials        792      793       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Axsasf
Fix pyramid slant height error message
8e2bbc0
Axsasf
Axsasf commented Nov 2, 2026
View reviewed changes
Comment thread src/main/java/com/thealgorithms/maths/Area.java
if (slantHeight <= 0) {
throw new IllegalArgumentException("slant height must be greater than 0");
}
if (sideLength <= 0) {

@Axsasf Axsasf Nov 2, 2026

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated validation messages clearly explain that both sideLength and slantHeight must be positive. This makes invalid input errors easier to understand.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan will be requested when the pull request is marked ready for review DenizAltunkapan is a code owner
@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme will be requested when the pull request is marked ready for review yanglbme is a code owner
@alxkm alxkm Awaiting requested review from alxkm alxkm will be requested when the pull request is marked ready for review alxkm is a code owner

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Axsasf @codecov-commenter
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.