GeezerVison is showing github.com — feat(strings): add suffix array algorithm by hasnain607 · Pull Request #15688 · TheAlgorithms/Python
Conversation
Describe your change
- Add an algorithm?
- Fix a bug or typo in an existing algorithm?
- Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
- Documentation change?
Checklist
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized.
- I know that pull requests will not be merged if they fail the automated tests.
- This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- All new Python files are placed inside an existing directory.
- All filenames are in all lowercase characters with no spaces or dashes.
- All functions and variable names follow Python naming conventions.
- All function parameters and return values are annotated with Python type hints.
- All functions have doctests that pass the automated testing.
- All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
- If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@mindaugl , @cclauss please review my PR, I know you guys must be busy for taking so long at responding to open PRs
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
What is the advantage over suffix trees?
Thanks for the review! The main advantages are memory and simplicity. A suffix array stores one integer per suffix, while a suffix tree needs up to 2n nodes, each holding child pointers
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hasnain607
commented
Nov 6, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@cclauss @darkstar , I am very sorry for pinging you guys, but I am very excited for my first contribution if you will look into my PR please, tell me if I am missing out on something. Thanks for your time
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.