GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: handle Unicode in Adler-32 checksum by SwetaKumari7 · Pull Request #15692 · TheAlgorithms/Python

Conversation

@SwetaKumari7

@SwetaKumari7 SwetaKumari7 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes Unicode handling in the Adler-32 checksum implementation.

Changes

  • Encode input strings as UTF-8 before processing.
  • Iterate over bytes instead of Unicode characters.
  • Preserve the existing function signature and return type.
  • Add doctests for Unicode strings and empty input.
  • Preserve existing ASCII test cases.

Testing

  • python -m doctest hashes/adler32.py
  • ruff check hashes/adler32.py
  • ruff format --check hashes/adler32.py
  • git diff --check

Also verified Unicode checksum results against Python's zlib.adler32().

Fixes #15635

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SwetaKumari7
fix: handle Unicode in Adler-32 checksum
aaa0566
@SwetaKumari7 SwetaKumari7 mentioned this pull request Nov 5, 2026
fix: handle Unicode in Adler-32 checksum SwetaKumari7/SECOND_CONTRIBUTION#1
Closed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hashes/adler32.py: checksum diverges from the Adler-32 spec for any non-ASCII input (sums Unicode code points instead of bytes)

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@SwetaKumari7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.