GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support shared library build by uilianries · Pull Request #686 · ThrowTheSwitch/Unity

Conversation

@uilianries

@uilianries uilianries commented Jul 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

So far is only possible to build Unity as static library, but actually it would be nice if was possible to not enforce only static, but enabling both configurations.

This pull request removes the STATIC directive from add_library and exports all symbols when building on Windows, only when as shared.

Plus, I added an entire workflow to validate Unity with CMake, building as static and shared library.

Latest build result (commit 11e95e2): https://github.com/uilianries/Unity/actions/runs/5553214628

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RossSmyth reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
uilianries added 11 commits July 14, 2023 12:01
@uilianries
Support shared library build
c6b7bbe 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
build for any branch
4ca66a2 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Use python to install deps
b05426f 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Add shared build
70c3c71 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Use real bool
856ac8a 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Prepare Windows environment
ab52acb 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
enable extensions
747d0ab 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
use msvc generator for windows
3f1d569 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
skip default runner
63cfdd1 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
manage skip defult runner
e38bce4 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
manage skip defult runner
11e95e2 
Signed-off-by: Uilian Ries <[email protected]>
AJIOB
AJIOB reviewed Jul 28, 2023
View reviewed changes
Comment thread CMakeLists.txt
target_compile_definitions(${PROJECT_NAME}
PRIVATE
# Enable shared library
$<$<BOOL:${BUILD_SHARED_LIBS}>:UNITY_SKIP_DEFAULT_RUNNER>

@AJIOB AJIOB Jul 28, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding option for BUILD_SHARED_LIBS, as described in cmake docs?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@AJIOB AJIOB AJIOB left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@uilianries @AJIOB
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.